Search code examples
cgcc-warning

GCC compiler warning: format ‘%c’ expects argument of type ‘char *’, but argument 2 has type ‘int *’ [-Wformat]

I get the following warning when I try to compile the code:

exercise6.c:32:14: warning: format ‘%c’ expects argument of type ‘char *’, but argument 2 has type ‘int *’ [-Wformat]

What is causing this warning and how do I fix it?

/*Write a program that displays the contents of a file at the terminal 20 lines at
a time. At the end of each 20 lines, have the program wait for a character to be
entered from the terminal. If the character is the letter q, the program should
stop the display of the file; any other character should cause the next 20 lines
from the file to be displayed.*/

#include <stdio.h>
#include <stdlib.h>

int main (void)
{
    int c, i;
    FILE *file;

    if ( (file = fopen ("text", "r")) == NULL )
    printf ("Error opening the file.\n");

    for ( i = 0; i < 20; ) {
        c = getc (file);

        if ( c == EOF ) {
            fclose (file);
            exit (EXIT_SUCCESS);
        }

        putc (c, stdout);

        if ( c == '\n' )
            ++i;

        if ( i == 20 ) {
            scanf ("%c", &c);
            if ( c == 'q' ) {
                fclose (file);
                exit (EXIT_SUCCESS);
            }
            i = 0;
        }
    }
}
Solution

  • Define a char ch and use that in scanf.

    int c, i;
char ch;

/* ... */
scanf ("%c", &ch);

    Using mismatched arguments for scanf is technically undefined behavior.