Search code examples
c++cpixelmemcpyflip

Simple Flip buffer (Vertically) issue in C\C++


I am trying to flip a buffer, but the buffer doesn't get fully processed. Is a buffer of pixels and I need basically to flip it vertically. Can anyone spot what am I doing wrong? Thanks in advance.

void flipVertically(unsigned int* buffer, const unsigned int width, const unsigned int height)
{
    const unsigned int rowWidth = width; // Length of a row
    const unsigned int rows = height / 2; // Iterate only half the buffer to get a full flip
    unsigned int* tempRow = (unsigned int*)malloc(rowWidth);

    for (int rowIndex = 0; rowIndex < rows; rowIndex++)
    {
        memcpy(tempRow, buffer + (rowIndex * rowWidth), rowWidth);
        memcpy(buffer + (rowIndex * rowWidth), buffer + (height - rowIndex - 1) * rowWidth, rowWidth);
        memcpy(buffer + (height - rowIndex - 1) * rowWidth, tempRow, rowWidth);
    }

    free(tempRow);
}

Solution

  • Will this work?

    void flip(unsigned* buffer, unsigned width, unsigned height)
    {
        unsigned rows = height / 2; // Iterate only half the buffer to get a full flip
        unsigned* tempRow = (unsigned*)malloc(width * sizeof(unsigned));
    
        for (unsigned rowIndex = 0; rowIndex < rows; rowIndex++)
        {
            memcpy(tempRow, buffer + rowIndex * width, width * sizeof(unsigned));
            memcpy(buffer + rowIndex * width, buffer + (height - rowIndex - 1) * width, width * sizeof(unsigned));
            memcpy(buffer + (height - rowIndex - 1) * width, tempRow, width * sizeof(unsigned));
        }
    
        free(tempRow);
    }