Search code examples
objective-cnsmutablearraycollatznsmutableset

Objective c, reverse Collatz, help me debug NSArrays


I am working on a math fair project using the Collatz conjecture, I am wanting to make a reverse graph as you can find here on wikipeadia although I have found that I have messed up somewhere in my code and it doesn't show all of the reverse values (ex it will find one odd value from an array then that same value *2 but it won't go past that).

    #import "numberCreator.h"

@implementation numberCreator
@synthesize levels, nextX, nextY, numbers;

- (id)init
{
    self = [super init];
    if (self) {
        numbers         = [[NSMutableArray alloc]initWithCapacity:1000];//gives the array an estamated cap.
        currentLevel    = [[NSMutableArray alloc]initWithCapacity:25];
        nextLevel       = [[NSMutableArray alloc]initWithCapacity:25];
        checkNumbers    = [[NSMutableSet alloc]init];
    }

    return self;
}

//Creates all of the needed numbers in the reverce Collatz Web
- (void) create{
    [currentLevel addObject:[NSNumber numberWithInt:1]];
    [numbers addObject:[NSNumber numberWithInt:1]];
    [numbers addObject:[NSNumber numberWithInt:0]];
    [numbers addObject:[NSNumber numberWithInt:0]];
    [checkNumbers addObject:[NSNumber numberWithInt:1]];

    for(int x; x < levels; x++){
        for(int y; y < [currentLevel count]; y++){
            if([checkNumbers containsObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]floatValue]*2]]){}
            else{
                [checkNumbers addObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]intValue]*2]];

                [numbers addObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]intValue]*2]];
                [numbers addObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]intValue]]];//The array is set like Number, Parent, level
                [numbers addObject:[NSNumber numberWithInt:x+1]];

                [nextLevel addObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]intValue]*2]];
                if((y-1)/3%2==1){
                    if([checkNumbers containsObject:[NSNumber numberWithInt:([[currentLevel objectAtIndex:y]floatValue]-1)/3]]){}
                    else{
                        [checkNumbers addObject:[NSNumber numberWithInt:([[currentLevel objectAtIndex:y]intValue]-1)/3]];


                        [numbers addObject:[NSNumber numberWithInt:([[currentLevel objectAtIndex:y]intValue]-1)/3]];
                        [numbers addObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]intValue]]];
                        [numbers addObject:[NSNumber numberWithInt:x+1]];

                        [nextLevel addObject:[NSNumber numberWithInt:[[currentLevel objectAtIndex:y]intValue]*2]];
                    }
                }else{}
            }

        }

        [currentLevel removeAllObjects];
        for(int y; y < [nextLevel count]; y++){
            [currentLevel addObject:[nextLevel objectAtIndex:y]];
        }
        [nextLevel removeAllObjects];
    }

    for(int x; x < [numbers count]; x++){
        NSLog(@"%i", [[numbers objectAtIndex:x]intValue]);
    }
}

@end

Solution

  • Because, you work only with integer, using a NSMutableIndexSet would be much more efficient.

    #import "NumberCreator.h"
    
    @implementation NumberCreator
    @synthesize levels, numbers;
    
    - (id)init
    {
        if ( !(self = [super init] ) )
            return nil;
    
        numbers = [NSMutableIndexSet new];
        return self;
    }
    
    - (void)create
    {
        [numbers removeAllIndexes];
        [numbers addIndex:1];
    
        NSMutableIndexSet *nextLevel = [NSMutableIndexSet indexSet];
        NSMutableIndexSet *currentLevel = [NSMutableIndexSet indexSetWithIndex:1];
    
        for (int i = 0; i < levels; i++ )
        {
            [currentLevel enumerateIndexesUsingBlock:^(NSUInteger idx, BOOL *stop) {
    
                if ( ! [numbers containsIndex:idx * 2] )
                    [nextLevel addIndex:idx * 2];
    
                if ( idx % 6 == 4 && ! [numbers containsIndex:(idx - 1) / 3] )
                    [nextLevel addIndex:(idx - 1) / 3];
            }];
    
            [numbers addIndexes:nextLevel];
            [currentLevel removeAllIndexes];
            [currentLevel addIndexes:nextLevel];
            [nextLevel removeAllIndexes];
        }
    
        [numbers enumerateIndexesUsingBlock:^(NSUInteger idx, BOOL *stop) {
            NSLog(@"%i", idx);
        }];
    }
    
    @end