Find nested object by Id using for loop in Javascript

Question

I'm trying to find a specific Object in a nested Object by id and wrote this function, which works like a charm:

const findNestedObjById = (tree, myFunction, id) => {
  if(tree.attributes.node_id === id){
    myFunction(tree)
  } else{
    if(tree.children){
      tree.children.forEach(child => {
        findNestedObjById(child, myFunction, id)      
      });
    }    
  }
};

const doThat = (tree) => {
  console.log("Got it: " + tree.name)
}

findNestedObjById(myObj, doThat, "0.1.2.1");

But i want to be able to get the "path" of the object (e.g. myObj.children[0].children[2]) (The children property of my object is an array) So I wanted to rewrite the function using a fori loop instead of a foreach, so that I could later add the index of the array (saved in i of the fori loop at the time) to a path string.

So I wanted to start with this function:

const findWithFori = (tree, myFunction, id) => {
  if(tree.attributes.node_id === id){
    myFunction(tree)
  } else{
    if(tree.children){
      for (let i = 0; i < tree.length; i++) {
        const child = tree.children[i];
        findNestedObjById(child, myFunction, id) 
      }
    }    
  }
};

But it doenst work, it's able to locate the object by id, if the inital myObj already has the right id, but it doesn't find nested objects, like the first function does and I don't understand why.

If it helps answerign the question, myObj looks like this btw.:

const myObj = {
  name: "Mein zweiter Baum",
  attributes: {
    node_id: "0"
  },
  children: [
    {
      name: "Lorem",
      attributes: {
        node_id: "0.1",
        done: true
      },
      children: [
        {
          name: "Ipsum",
          attributes: {
            node_id: "0.1.1",
            done: true
          },
          children: [
            {
              name: "Dolor",
              attributes: {
                node_id: "0.1.1.1",
                done: false
              }
            }
          ]
        },
        {
          name: "Sit",
          attributes: {
            node_id: "0.1.2",
            done: false
          },
          children: [
            {
              name: "Anet",
              attributes: {
                node_id: "0.1.2.1"
              }
            }
          ]
        }
      ]
    }
  ]
};

Answer 1

You could return the indices.

If an item is found return an empty array, or undefined. Inside of some get the result of children and if not undefined add the actual index in front of the array.

const
    findNestedObjById = (tree, id, callback) => {
        if (tree.attributes.node_id === id) {
            callback(tree);
            return [];
        }
        if (tree.children) {
            let path;
            tree.children.some((child, index) => {
                path = findNestedObjById(child, id, callback);
                if (path) {
                    path.unshift(index);
                    return true;
                }
            });
            return path;
        }
    },
    doThat = tree => {
        console.log("Got it: " + tree.name);
    },
    data = { name: "Mein zweiter Baum", attributes: { node_id: "0" }, children: [{ name: "Lorem", attributes: { node_id: "0.1", done: true }, children: [{ name: "Ipsum", attributes: { node_id: "0.1.1", done: true }, children: [{ name: "Dolor", attributes: { node_id: "0.1.1.1", done: false } }] }, { name: "Sit", attributes: { node_id: "0.1.2", done: false }, children: [{ name: "Anet", attributes: { node_id: "0.1.2.1" } }] }] }] }

console.log(findNestedObjById(data, "0.1.2.1", doThat)); // [0, 1, 0]

.as-console-wrapper { max-height: 100% !important; top: 0; }