Search code examples
javaandroidsockets

Socket Server controller Android App, Socket error


So basically I want to create some kind of controller for my pc, where on pc, runs java socket server. The server is working, I have tried it. Also, Port Forwarding in the router is allright. Source code is here :

import java.io.DataInputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import java.net.ServerSocket;
import java.net.Socket;
import java.util.Scanner;

public class Server {
    public static final String ANSI_RESET = "\u001B[0m";
    public static final String ANSI_GREEN = "\u001B[32m";
    public static final String ANSI_BOLD = "\033[1m";
    public static final String ANSI_RED = "\u001B[31m";

    public static void main(String[] args) throws IOException {

        // Creating server instance
        ServerSocket serverSocket = new ServerSocket(2000);
        Socket socket = serverSocket.accept();

        System.out.println(ANSI_GREEN + "Controller connected" + ANSI_RESET);

        // Input Output streams
        DataInputStream dataInputStream = new DataInputStream(socket.getInputStream());
        DataOutputStream dataOutputStream = new DataOutputStream(socket.getOutputStream());

        String command = "";

        do {

            command = dataInputStream.readUTF();

            switch (command.trim()){
                case "volume up":
                    Runtime.getRuntime().exec("cmd /c start src\\sk\\dzurik\\main\\volup.bat");
                    break;
                case "volume down":
                    Runtime.getRuntime().exec("cmd /c start src\\sk\\dzurik\\main\\voldown.bat");
                    break;
                default:
                    // Unknown command
                    break;
            }



        }while (!command.equals("stop"));

        socket.close();

        System.out.println(ANSI_RED + "Controller disconnected" + ANSI_RESET);

    }

}

And it is supposed to interact with the android app, but I got an error and I can't quite figure out why is that so, here is the source code for ActivityMain :

import androidx.appcompat.app.AppCompatActivity;

import android.content.Context;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.Toast;

import java.io.DataOutputStream;
import java.io.IOException;
import java.net.Socket;

public class MainActivity extends AppCompatActivity {
    private boolean connected;
    private DataOutputStream dataOutputStream;
    private Socket socket;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        // Pripájanie na server

        try {
            socket = new Socket("172.0.0.1",2000);
            dataOutputStream = new DataOutputStream(socket.getOutputStream());

        } catch (IOException e) {
            Toast.makeText(MainActivity.this, "Not Connected!",
                    Toast.LENGTH_LONG).show();
        }


        Button VolumeUp = (Button) findViewById(R.id.VolumeUpButton);
        VolumeUp.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                try {
                    send("volume up");
                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        });

        Button VolumeDown = (Button) findViewById(R.id.VolumeDownButton);
        VolumeDown.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                try {
                    send("volume down");
                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        });

        Button DisconnectButton = (Button) findViewById(R.id.DisconnectButton);
        DisconnectButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                try {
                    send("stop");

                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        });

    }


    public void send(String command) throws IOException {
        if (socket != null){
            dataOutputStream.writeUTF(command);
        }
        else Toast.makeText(MainActivity.this, "Socket is not defined",
                Toast.LENGTH_SHORT).show();
    }

    public void disconnect() throws IOException {
        if (socket != null){
            socket.close();
        }
        else Toast.makeText(MainActivity.this, "Socket is not defined",
                Toast.LENGTH_SHORT).show();
    }

}

So if you could help me with it, I would be thankful, <3


Solution

  • Well the reason for that was silly. When I'm loading data from Stream it says nextLine which means the ending point is \n so I could never get that line because I haven't put it there.