Search code examples
javascripthtmljquerycycle

Cycle through divs up and down with Jquery


I need to cycle up and down through two sets of divs simultaneously. This code works well for cycling up the list (button1) but when I tried to create a down button (button2) it messes up the div order and doesn't cycle correctly. How can I alter this code to make it successfully cycle up and down through the list in the correct order?

$(document).ready(function() {
  var divs = $('div[id^="num-"]').hide(),
    i = 0;

  function cycleone() {
    divs.hide().eq(i).show();
    i = ++i % divs.length;
  };
  
  cycleone()
  
  $('#button1').click(function() {
    cycleone()
  })
});

$(document).ready(function() {
  var divsv = $('div[id^="numv-"]').hide(),
    iv = 0;

  function cycletwo() {
    divsv.hide().eq(iv).show();
    iv = ++iv % divsv.length;
  };

  cycletwo()
  
  $('#button1').click(function() {
    cycletwo()
  })
});

$(document).ready(function() {
  var divs = $('div[id^="num-"]').hide(),
    i = 0;

  function cycleonedown() {
    divs.hide().eq(i).show();
    i = --i % divs.length;
  };
  
  cycleonedown()
  
  $('#button2').click(function() {
    cycleonedown()
  })
});

$(document).ready(function() {
  var divsv = $('div[id^="numv-"]').hide(),
    iv = 0;

  function cycletwodown() {
    divsv.hide().eq(iv).show();
    iv = --iv % divsv.length;
  };

  cycletwodown()
  
  $('#button2').click(function() {
    cycletwodown()
  })
});
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>

<div id="num-1">1</div>
<div id="num-2">2</div>
<div id="num-3">3</div>
<div id="num-4">4</div>
<div id="num-5">5</div>
<div id="num-6">6</div>
<div id="num-7">7</div>

<div id="numv-1">A</div>
<div id="numv-2">B</div>
<div id="numv-3">C</div>
<div id="numv-4">D</div>
<div id="numv-5">E</div>
<div id="numv-6">F</div>
<div id="numv-7">G</div>

<button id="button1">Up</button>
<button id="button2">Down</button>


Solution

  • As i can see you are using jquery, try the snippet below

    $(document).ready(function(){
        var lettersArray=[];
        var step=1;
        var lastStep=parseInt($(document).find('.num').length);
        
        if($(document).find('.numv').length){
            $(document).find('.numv').each(function(){
                var letter=$(this).html();
                lettersArray.push(letter);
            });
        }
        
        showCycle=function(step){
            var stepLetter=lettersArray[step-1];
            $('#number').html(step);
            $('#letter').html(stepLetter);
        }
        $(document).on('click','#button1',function(){
            step=step+1;
            step=step > lastStep ? 1 : step;
            showCycle(step);
        });
        
        $(document).on('click','#button2',function(){
            step=step-1;
            step=step < 1 ? lastStep : step;
            showCycle(step);
        });
        
    });
    .num, .numv{
        display:none;
    }
    <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.8.1/jquery.min.js"></script>
    
    <div id="num-1"class="num">1</div>
    <div id="num-2"class="num">2</div>
    <div id="num-3"class="num">3</div>
    <div id="num-4"class="num">4</div>
    <div id="num-5"class="num">5</div>
    <div id="num-6"class="num">6</div>
    <div id="num-7"class="num">7</div>
    
    <div id="numv-1"class="numv">A</div>
    <div id="numv-2"class="numv">B</div>
    <div id="numv-3"class="numv">C</div>
    <div id="numv-4"class="numv">D</div>
    <div id="numv-5"class="numv">E</div>
    <div id="numv-6"class="numv">F</div>
    <div id="numv-7"class="numv">G</div>
    
    <div id="number">1</div>
    <div id="letter">A</div>
    
    <button id="button1">Up</button>
    <button id="button2">Down</button>