Search code examples
javapluginsminecraftbukkit

Bukkit.getPlayer() throws a number format exception


I'm pretty new to Minecraft plugin development and I'm trying to make my own lite version of the essentials plugin. I'm trying to make a command that will allow me to set my fly speed as well as the fly speed of others. setting speed works just fine, however, targeting other players is something I can't seem to manage. When I execute the command, this appears in the log:

[23:55:50 INFO]: swalloich issued server command: /flyspeed swalloich 2
[23:55:50 INFO]: swalloichtargeted swalloich with the flySpeed command.
[23:55:50 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'flyspeed' in plugin EssentialsLite v0.2
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:148) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at org.bukkit.craftbukkit.v1_16_R2.CraftServer.dispatchCommand(CraftServer.java:735) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.PlayerConnection.handleCommand(PlayerConnection.java:1647) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.PlayerConnection.a(PlayerConnection.java:1504) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(SourceFile:36) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.PacketPlayInChat.a(SourceFile:9) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.TickTask.run(SourceFile:18) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeTask(SourceFile:144) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.executeNext(SourceFile:118) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.MinecraftServer.ba(MinecraftServer.java:899) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.MinecraftServer.executeNext(MinecraftServer.java:892) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.IAsyncTaskHandler.awaitTasks(SourceFile:127) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.MinecraftServer.sleepForTick(MinecraftServer.java:876) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.MinecraftServer.w(MinecraftServer.java:815) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at net.minecraft.server.v1_16_R2.MinecraftServer.lambda$0(MinecraftServer.java:155) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    at java.lang.Thread.run(Thread.java:832) [?:?]
Caused by: java.lang.NumberFormatException: For input string: "swalloich"
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:68) ~[?:?]
    at java.lang.Integer.parseInt(Integer.java:652) ~[?:?]
    at java.lang.Integer.parseInt(Integer.java:770) ~[?:?]
    at me.swall.essentialsLite.commands.FlySpeed.onCommand(FlySpeed.java:62) ~[?:?]
    at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[craftbukkit-1.16.2.jar:git-Bukkit-43c7ff9]
    ... 18 more

The portion of my code that I'm almost positive that it stems from is this:

    float flySpeed = (float)(Integer.parseInt(args[1]) / 10.0);
    Bukkit.getLogger().info(player.getDisplayName() + " targeted " + args[0] + " with the flySpeed command.");
    if (Integer.parseInt(args[0]) > 10 || Integer.parseInt(args[0]) < 0)
    {
        sender.sendMessage("The speed argument must be a whole number between 0 and 10.");
    }
    else
    {
        //set the target player's fly speed to the value provided as the second argument
        Player targetPlayer = Bukkit.getPlayerExact(args[0]);
        Bukkit.getLogger().info("targetPlayer was initialized.");
        if (targetPlayer != null && player.isOnline())
        {
            targetPlayer.setFlySpeed(flySpeed);
            Bukkit.getLogger().info("The fly speed for user " + player.getDisplayName() 
                                    + " has been set to" + args[0]);
        }
        else
        {
            sender.sendMessage("That player was not found.");
        }
    }

What am I doing wrong?


Solution

  • At the line 1 of the code, You are dividing String (args[1]) against float (10.0).

      float flySpeed = (float)(Integer.parseInt(args[1] / 10.0));
    

    It should be changed into this:

      float flySpeed = (float)(Integer.parseInt(args[1]) / 10.0);
    

    + if you are going to use parsed integer multiple times in the code, I recommend creating integer variable for that.

    If then, code will be look like this:

        int flySpeedArg = Integer.parseInt(args[1]);
        float flySpeed = (float)(Integer.parseInt(args[1]) / 10.0);
    
        Bukkit.getLogger().info(player.getDisplayName() + " targeted " + args[0] + " with the flySpeed command.");
        if (flySpeedArg > 10 || flySpeedArg < 0)
        {
            sender.sendMessage("The speed argument must be a whole number between 0 and 10.");
        }
        else
        {
            //set the target player's fly speed to the value provided as the second argument
            Player targetPlayer = Bukkit.getPlayerExact(args[0]);
            Bukkit.getLogger().info("targetPlayer was initialized.");
            if (targetPlayer != null && player.isOnline())
            {
                targetPlayer.setFlySpeed(flySpeed);
                Bukkit.getLogger().info("The fly speed for user " + player.getDisplayName() 
                                        + " has been set to" + args[0]);
            }
            else
            {
                sender.sendMessage("That player was not found.");
            }
        }