Search code examples
javascripttypescriptangular7angular-directiveangular-components

How to convert exactPageList from any to any[] when assign it to pagefield?


I work on angular 7 app I face issue on paging cannot assign exactpagelist any to pagefield any[] .

because pagefield is type array and exactpagelist is type any .

issue exist on last line of function totalNoOfPages on this line

this.pageField = this.exactPageList;
this.pageField = 2; not correct

I expected to be

this.pageField = [1,2];

meaning i need to convert this.exactPageList; to array to be accepted assign to pagefield How to do that ?

pageField:any[];
exactPageList:any;
totalNoOfPages() {  

    this.paginationData = Number(this.totalReportCount / this.ReportPerPage);  
    console.log("pagination data :" + this.paginationData)
    let tempPageData = this.paginationData.toFixed(); 
    console.log("tempPageData data :" + tempPageData) 
    if (Number(tempPageData) < this.paginationData) {  
      this.exactPageList = Number(tempPageData) + 1;  
      this.paginationService.exactPageList = this.exactPageList;  
      console.log("exactPageList1  data :" + this.exactPageList ) 
    } else {  
      this.exactPageList = Number(tempPageData);  
      this.paginationService.exactPageList = this.exactPageList  
      console.log("exactPageList2  data" + this.exactPageList ) 
    }  
    this.paginationService.pageOnLoad();  
    this.pageField = this.exactPageList;    

  }  

Result of code above as below :

pagination data1.0666666666666667
reportdetails.component.ts:265 tempPageData data1
reportdetails.component.ts:269 exactPageList1  data2
reportdetails.component.ts:263 pagination data1.0666666666666667
reportdetails.component.ts:265 tempPageData data1
reportdetails.component.ts:269 exactPageList1  data2

Expected result

this.pageField = [1,2];

Solution

  • Some explanation by using comments:

    this.paginationData = Number(this.totalReportCount / this.ReportPerPage);  
    console.log("pagination data :" + this.paginationData)
    // Use Math.round instead. Then you get an numeral and not a string.
    let tempPageData = this.paginationData.toFixed(); 
    console.log("tempPageData data :" + tempPageData) 
    // Then Number() is not necessary here anymore.
    // Moreover as far as I understand, you actually want to use always the 'bigger number'. 
    // That means, actually it would make sense to use Math.ceil() above.
    // In that case, you don't need to use a condition at all.
    if (Number(tempPageData) < this.paginationData) {  
      this.exactPageList = Number(tempPageData) + 1;  
      this.paginationService.exactPageList = this.exactPageList;  
      console.log("exactPageList1  data :" + this.exactPageList ) 
    } else {  
      // You are doing almost the same like in the condition clause above.
      // It would be enough to set this.exactPageList condtionally and do the rest afterwards.
      this.exactPageList = Number(tempPageData);  
      this.paginationService.exactPageList = this.exactPageList  
      console.log("exactPageList2  data" + this.exactPageList ) 
    }  
    this.paginationService.pageOnLoad();  
    this.pageField = this.exactPageList; 
    

    What I would do:

    this.paginationData = Number(this.totalReportCount / this.ReportPerPage);  
    console.log("pagination data :", this.paginationData)
    let tempPageData = Math.ceil(this.paginationData);
    console.log("tempPageData data :", tempPageData) 
    // Let's create an array from 1 .. N
    // [...Array(4).keys()] would create an array with [0,1,2,3]
    // but we want to have [1,2,3,4], that's why we are incrementing every value by using map(). 
    // Think about moving this to an own method 'getOneToNArray' or so for a better readability.
    this.exactPageList = [...Array(tempPageData).keys()].map(x => ++x);;
    this.paginationService.exactPageList = this.exactPageList;  
    console.log("exactPageList data :", this.exactPageList )   
    this.paginationService.pageOnLoad();  
    this.pageField = this.exactPageList;