I have a session that starts if a user logs in, but certain code may be hit asking for session variables that may not exist yet, is there still a way of checking the variable here or is there another way to go about it.
PHP runs hiding a box, if a user isn't an admin, but that check could happen before the user logs in. how would i go about checking that session variables value?
I have tried moving the code to hide the box to a seperate page, like the log in page, but to no avail, the log in is a popup by the way not another window.
session_start();
$connect= new mysqli('localhost', 'root', '', 'login') or die("connection failure, please try again later");
$username= $_GET["username"] ?? '';
$password= $_GET["password"] ?? '';
echo "<br>","$username";
$getsalt="SELECT * FROM users WHERE uname='$username'";
$salt= $connect->query($getsalt);
$currentsalt = "";
while($row=$salt->fetch_assoc()) {
$currentsalt = $row["salt"];
$_SESSION["uname"] = $row["uname"];
$_SESSION["id"] = $row["id"];
echo'<br>', 'is admin ', $row['is_admin'];
$_SESSION["is_admin"] = 1;
if($row["is_admin"] == 1) {
echo 'is admin';
$_SESSION["is_admin"] = 1;
} else {
echo 'is not admin';
}
}
echo "<br>","$password";
echo "<br>", $currentsalt;
if($currentsalt == null) {
echo "user doesnt exist";
} else {
$hashed= sha1($password.$currentsalt);
echo "<br>", $hashed;
$getaccount="SELECT * FROM users WHERE uname='$username' AND pass='$hashed'";
$result= $connect->query($getaccount);
if($result-> num_rows>0) {
while($row=$result->fetch_assoc()) {
echo "<br>","Admin name is: " . $row["uname"];
header("Location: /index.php");
}
} else {
echo "<br>","sorry password was incorrect";
}
}
Edit: Added a new answer based on the latest comments.
I will answer your question in two parts.
You can check if a variable exists by using empty()
if (empty($_SESSION['is_admin'])) {
// do the action if the currently logged in user is not an admin
} else {
// do the action if an admin user is logged in
}
No warning is generated if the variable does not exist. That means empty() is essentially the concise equivalent to !isset($var) || $var == false.
It is recommended to add a login check at the top of all pages those are reserved for logged in users.
You can add a login check as follows.
Create a helper function called checkLogin()
function checkLogin(){
if (!empty($_SESSION['user_id'])) {
return true;
} else {
header("Location: https://YOUR_LOGIN_PAGE_URL");
die();
}
Then, wherever you want to restrict unauthorised users accessing the page, include this checkLogin()
function.
Be sure you have added this function in a file common to your application