Search code examples
phpsearch-engine

PHP - display error if search unsuccessful

I'm having trouble with my search script.

Basically, all is fine with the search if the result is found but if there are no matches in the DB(MySQL) then my error doesn't display.. am i missing something? heres the code:

<?php
$term = $_GET['term'];
$sql = mysql_query("select * from search_e where content like '%$term%'");
while ($row = mysql_fetch_array($sql)){ 
$data = $row['content'];
$first_pos = strpos($data,$term);
if ($first_pos !== false) {
                  $output = substr($data,max(0,$first_pos - 100),200 + strlen($term));?>


<div>
<p class="ptitle"><?php echo $row["fn"]; ?></p><hr>
            Brief summary of contents:
            <hr class="hr">
            <p style="padding: 5px;">
        <i>"<?php echo $output; ?>" </i>..
            </p>


</div><br><br>
<?php
}
else  {?>
<div><?php echo "Sorry! No results were found using term: ".$_GET['term']."<br>Try using fewer Keywords"; ?></div>
<?php }?>
<?php
}
//close
    mysql_close();

?>

This may be something simple im doing wrong but i just cant figure it out. Also i know the code is dirty but its how i work.

I was also hoping to implement a little snippet i found browsing the net, which higlights specific words in a phrase. 

function highlight($sString, $aWords) {
    if (!is_array ($aWords) || empty ($aWords) || !is_string ($sString)) {
        return false;
    }

    $sWords = implode ('|', $aWords);
    return preg_replace ('@\b('.$sWords.')\b@si', '<strong style="background-color:yellow">$1</strong>', $sString);
}

Is this possible to work into my script??

Solution

  • If I'm clear about what you're trying to accomplish, I would change it like so:

    if(mysql_num_rows($sql) > 0) {
    while ($row = mysql_fetch_array($sql)) { 
        ...
    }
} else {
    echo("No Records!");
}

    And barfoon is correct. Protect your web site and backend database from malicious users.

    $term = mysql_real_escape_string($_GET['term']);

    Edit

    For completeness, after looking back over what you posted the reason you are getting no output is because if no matches are found anything inside of the while loop will not be executed, so your if($first_pos !== false) check is meaningless, except as a sort of 'sanity check' for records that did match.

    To highlight the words using the function you posted, change:

    <i>"<?php echo $output; ?>" </i>

    To:

    <i>"<?php echo highlight($output, array( $term )); ?>" </i>