Search code examples
c#.netformatstringbuilder

Does this AppendFormat have any value?

I'm currently working on a project that was written a few years ago.

I ran into this line:

stringBuilder.AppendFormat("{0}", value);

As far as I can see, the fact it is being "formatted" makes no difference. There are no other characters being inserted, just value.

Why would the programmer write this line as AppendFormat, when it could have been written using Append, with less code?

value is a string.

Solution

  • Specifically for this example. I found the line and had a look at the source control history.

    The programmer essentially completely rewrote the method, but kept some lines in there (this included).

    I can only guess that the programmer forgot to revert the line back to .Append after removing the value initially in there.

    A bug without consequence, nightmare fuel.