An std::set
is a sorted associative container that offers fast lookup of it's elements. Keys are inserted in a sorted fashion and keys can't be modified once inserted to preserve that order.
Consider the following demonstration that constructs an std::set
of int*
and then tries to break it's elements' sorting :
#include <iostream>
#include <set>
int values[] = { 50, 40, 30, 20, 10 };
// Comparator that sorts by pointed value
struct comparator {
bool operator()(const int* left, const int* right) const {
return *left < *right;
}
};
using my_set_t = std::set<int*, comparator>;
// Checks if each of the elements of `values` are in the set
void output(const my_set_t & foo)
{
for (auto & x : values) {
std::cout << x << ' ' << foo.count(&x) << '\n';
}
std::cout << std::endl;
}
int main()
{
// Insert the address of each element of `values` into the set
my_set_t foo;
for (auto & x : values) {
foo.emplace(&x);
}
output(foo);
// Changing `values[1]` to zero should break the sorting of the set
values[1] = 0;
output(foo);
}
The output I got was :
50 1
40 1
30 1
20 1
10 1
50 1
0 0
30 0
20 0
10 0
The expression values[1] = 0;
effectively alters one of the set
's keys indirectly. This breaks the ordering and consequently seems to also break count
. I assume this would also break most of the set
's other functionalities.
There is obviously something wrong with the code. As far as I can tell it follows all language rules and I doesn't seem to violate any requirement that I could find for the compare function or set
. But the guaranties provided by set
are nonetheless broken, meaning I must have missed something.
In C++17, there is [associative.reqmts]/3:
... For any two keys
k1
andk2
in the same container, callingcomp(k1, k2)
shall always return the same value.
Thus, your code has UB because it violates this requirement.