Search code examples
androidexpandablelistview

Android Studio: Adding new group/child to ExpandableListView messes up with the previous one

I am adding new group and child with no problem in a ExpandableListView, but the child of the previous group always gets changed when a new group/child is added.

On the picture below, I added the group = DO ZERO and child = 123.

addProd1

Now, when I add a new group = CORRECAO FINAL and child = 987, the child of the previous group (DO ZERO) also gets changed.

addProd2

I do not know why this is happening.

Here is how I implemented the object.

public class ExpandableObjectc {

    private String groupName;
    private ArrayList<ProductObject> productList;

    public ExpandableObjectc(String groupName, ArrayList<ProductObject> productList) {
        this.groupName = groupName;
        this.productList = productList;
    }

    public String getGroupName() {
        return groupName;
    }

    public void setGroupName(String groupName) {
        this.groupName = groupName;
    }

    public ArrayList<ProductObject> getProductList() {
        return productList;
    }

    public void setProductList(ArrayList<ProductObject> productList) {
        this.productList = productList;
    }
}

Here is how I implemented the adapter

public class ExpandableAdapterc extends BaseExpandableListAdapter {

    private Context context;
    private ArrayList<ExpandableObjectc> groupList;
    private ArrayList<ExpandableObjectc> groupListFull;

    public ArrayList<ExpandableObjectc> getMParent() {
        return groupList;
    }

    public ExpandableAdapterc(Context context, ArrayList<ExpandableObjectc> groupList) {
        this.context = context;
        this.groupList = groupList;
        this.groupListFull = new ArrayList<>(groupList);
    }

    @Override
    public int getGroupCount() {
        return groupList.size();
    }

    @Override
    public int getChildrenCount(int groupPosition) {
        ArrayList<ProductObject> productList = groupList.get(groupPosition).getProductList();
        return productList.size();
    }

    @Override
    public Object getGroup(int groupPosition) {
        return groupList.get(groupPosition);
    }

    @Override
    public Object getChild(int groupPosition, int childPosition) {
        ArrayList<ProductObject> productList = groupList.get(groupPosition).getProductList();
        return productList.get(childPosition);
    }

    @Override
    public long getGroupId(int groupPosition) {
        return groupPosition;
    }

    @Override
    public long getChildId(int groupPosition, int childPosition) {
        return childPosition;
    }

    @Override
    public boolean hasStableIds() {
        return true;
    }

    @Override
    public View getGroupView(int groupPosition, boolean isExpanded, View convertView, ViewGroup parent) {
        ExpandableObjectc group = (ExpandableObjectc) getGroup(groupPosition);
        if (convertView == null) {
            LayoutInflater layoutInflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            convertView = layoutInflater.inflate(R.layout.expandable_group, null);
        }

        TextView mGroupName = (TextView) convertView.findViewById(R.id.expandable_groupName);
        //ImageView mArrow = (ImageView) convertView.findViewById(R.id.expandable_arrow);

        mGroupName.setText(group.getGroupName());

        return convertView;
    }

    @Override
    public View getChildView(final int groupPosition, final int childPosition, boolean isLastChild, View convertView, ViewGroup parent) {
        ProductObject product = (ProductObject) getChild(groupPosition, childPosition);
        if (convertView == null) {
            LayoutInflater layoutInflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            convertView = layoutInflater.inflate(R.layout.item_product, null);
        }

        CircleImageView mImage = (CircleImageView) convertView.findViewById(R.id.item_productImage);
        TextView mCode = (TextView) convertView.findViewById(R.id.item_productCode);
        TextView mAmount = (TextView) convertView.findViewById(R.id.item_productAmount);
        TextView mPrice = (TextView) convertView.findViewById(R.id.item_productPrice);
        TextView mDescription = (TextView) convertView.findViewById(R.id.item_productDescription);
        ImageButton mProductDelete = (ImageButton) convertView.findViewById(R.id.item_productDelete);
        ImageButton mProductEdit = (ImageButton) convertView.findViewById(R.id.item_productEdit);
        ToggleButton mFavorite = (ToggleButton) convertView.findViewById(R.id.item_productFavorite);

        if (product.getImage() != null) {
            byte[] prodIMG = product.getImage();
            Bitmap bitmap = BitmapFactory.decodeByteArray(prodIMG,0,prodIMG.length);
            mImage.setImageBitmap(bitmap);
            //Log.i("debinf prodadapter", "Private Image != null for "+productList.get(position).getDescription());
        } else {
            mImage.setImageResource(R.drawable.shopping_cart_black_48dp);
        }

        mCode.setText(product.getCode());
        mAmount.setText(product.getAmount());
        mPrice.setText(product.getPrice());
        mDescription.setText(product.getDescription());

        mProductDelete.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                removeChildFromGroup(groupPosition, childPosition);
            }
        });

        return convertView;
    }

    @Override
    public boolean isChildSelectable(int groupPosition, int childPosition) {
        return true;
    }

    public void removeChildFromGroup(int groupPosition, int childPosition) {
        ExpandableObjectc group = (ExpandableObjectc) getGroup(groupPosition);
        group.getProductList().remove(childPosition);

        notifyDataSetChanged();
    }

    public void filterData(String query) {
        query = query.toLowerCase();
        groupList.clear();

        if (query.isEmpty()) {
            groupList.addAll(groupListFull);
        } else {
            for (ExpandableObjectc group : groupListFull) {
                ArrayList<ProductObject> productList = group.getProductList();
                ArrayList<ProductObject> newList = new ArrayList<>();
                for (ProductObject product : productList) {
                    if (product.getCode().toLowerCase().contains(query) || product.getDescription().toLowerCase().contains(query)) {
                        newList.add(product);
                    }
                }
                if (newList.size() > 0) {
                    ExpandableObjectc nGroup = new ExpandableObjectc(group.getGroupName(), newList);
                    groupList.add(nGroup);
                }
            }
        }
        notifyDataSetChanged();
    }
}

And here is how I add new group/child in the MainActivity, where groupName comes from the spinner showed on the first picture above.

private void writeProductOnDisk(String groupName) {
        boolean isGroup = false;

        ProductObject productObject = new ProductObject(imageViewToByte(mProductImage), mCode.getText().toString(), mAmount.getText().toString(), mPrice.getText().toString(), mDescription.getText().toString(),false);

        for (int i = 0; i < dataForExpandable.size(); i++) {
            if (groupName.equals(dataForExpandable.get(i).getGroupName())) {
                dataForExpandable.get(i).getProductList().add(productObject);
                isGroup = true;
                mProductListAdapter.notifyDataSetChanged();
                Log.i("debinf prodact", "groupName already exists "+ groupName);
                break;
            }
        }

        if (!isGroup) {
            productList.clear();
            productList.add(productObject);
            dataForExpandable.add(new ExpandableObjectc(groupName,productList));
            mProductListAdapter.notifyDataSetChanged();
            Log.i("debinf prodact", "groupName DO NOT exists, creating new one "+ groupName);
        }
    }

I do not know if the problem happens in the adapter or when I add new element to the dataForExpandable variable.

I appreciate any help!

EDIT

I've added a loop after adding new group/child to print what was inside the dataForExpandable variable and I can see that the problem is probably occurring in the adding method dataForExpandable.add(new ExpandableObjectc(groupName,productList));, because it seems that it overrides the previous group/child with the new one.

It's overridden all the products I put in groupName = Grupo Diamante with the new child I added in groupName = boa gatolino.

debinf prodact: groupName DO NOT exists, creating new one boa gatolino
debinf prodact: groupName is DO ZERO product is 123
debinf prodact: groupName is CORRECAO FINAL product is 987
debinf prodact: groupName is CORRECAO FINAL product is 111
debinf prodact: groupName is CORRECAO FINAL product is 223
debinf prodact: groupName is CORRECAO FINAL product is 741
debinf prodact: groupName is PARECE QUE AGORA FOI product is 555
debinf prodact: groupName is PARECE QUE AGORA FOI product is 369
debinf prodact: groupName is Grupo Diamante product is 357
debinf prodact: groupName is boa gatolino product is 357

What is the best way to add new group/child?

Solution

  • Instead of add item to dataForExpandable(Activity)/groupList(Adapter), it may be better to add item to groupListFull(Adapter) and call filterData() to update groupList. So try the following:

    Add these methods inside the adapter:

    public int getBackingListGroupCount() {
    return groupListFull.size();
}

public ExpandableObjectc getBackingListGroup(int groupPosition) {
    return groupListFull.get(groupPosition);
}

public void addBackingListGroup(ExpandableObjectc group) {
    groupListFull.add(group);
}

    Changes in Activity:

    private void writeProductOnDisk(String groupName) {
    boolean isGroup = false;

    SearchView searchView = findViewById(R.id.SearchView);

    ProductObject productObject = new ProductObject(imageViewToByte(mProductImage), mCode.getText().toString(), mAmount.getText().toString(), mPrice.getText().toString(), mDescription.getText().toString(),false);

    for (int i = 0; i < mProductListAdapter.getBackingListGroupCount(); i++) {
        if (groupName.equals(mProductListAdapter.getBackingListGroup(i).getGroupName())) {
            mProductListAdapter.getBackingListGroup(i).getProductList().add(productObject);
            isGroup = true;
            mProductListAdapter.filterData(searchView.getQuery().toString());
            Log.i("debinf prodact", "groupName already exists "+ groupName);
            break;
        }
    }

    if (!isGroup) {
        productList = new ArrayList<>();
        productList.add(productObject);
        mProductListAdapter.addBackingListGroup(new ExpandableObjectc(groupName,productList));
        mProductListAdapter.filterData(searchView.getQuery().toString());
        Log.i("debinf prodact", "groupName DO NOT exists, creating new one "+ groupName);
    }
}

    Hope it helps!