Search code examples
mysqlsqlpdoslim

Query return empty result but data exist


I'm using Slim with PDO with MySql for return a specific list of matches available in my database. My query is this:

SELECT m.*, 
       t.name AS home_team_name, 
       t2.name AS away_team_name 
FROM `match` m 
LEFT JOIN team t ON m.home_team_id = t.id 
LEFT JOIN team t2 ON m.away_team_id = t2.id
WHERE (home_team_id = 117 OR away_team_id = 117) AND round_id = 488

if I execute this query I'll get a list of matches:

enter image description here

but inside the API developed with Slim I get an empty array. This is the method structure:

$app->get('/match/get_matches_by_team/{round_id}/{team_id}/{type}', function (Request $request, Response $response, array $args)
{
  $query = "SELECT m.*,
  t.name AS home_team_name,
  t2.name AS away_team_name
  FROM `match` m
  LEFT JOIN team t ON m.home_team_id = t.id
  LEFT JOIN team t2 ON m.away_team_id = t2.id
  WHERE ";

  switch($args["type"])
  {
    case "home":
          $query .= "home_team_id = :team_id AND ";
    break;
    case "away":
        $query .= "away_team_id = :team_id AND ";
    break;
    default:
        $query .= "(home_team_id = :team_id OR away_team_id = :team_id) AND ";
    break;
  }

  $query .= "round_id = :round_id";

  $sql = $this->db->prepare($query);
  $sql->bindParam("team_id", $args["team_id"]);
  $sql->bindParam("round_id", $args["round_id"]);
  $sql->execute();

  $result = $sql->fetchAll();
  return $response->withJson($result);
});

what I did wrong?

Thanks in advance for any help.

UPDATE

If I do echo $query; return; I'll get:

SELECT m.*,
t.name AS home_team_name,
  t2.name AS away_team_name
  FROM `match` m
  LEFT JOIN team t ON m.home_team_id = t.id
  LEFT JOIN team t2 ON m.away_team_id = t2.id
  WHERE away_team_id = :team_id AND round_id = :round_id

supposing to pass away, if instead I pass all I'll get:

SELECT m.*,
t.name AS home_team_name,
  t2.name AS away_team_name
  FROM `match` m
  LEFT JOIN team t ON m.home_team_id = t.id
  LEFT JOIN team t2 ON m.away_team_id = t2.id
  WHERE (home_team_id = :team_id OR away_team_id = :team_id) AND round_id = :round_id

UPDATE 2

Method updated with proposed hints

$app->get('/match/get_matches_by_team
/{round_id}/{team_id}/{type}', function (Request $request, Response $response, array $args)
{
  $query = "SELECT m.*,
  t.name AS home_team_name,
  t2.name AS away_team_name
  FROM `match` m
  LEFT JOIN team t ON m.home_team_id = t.id
  LEFT JOIN team t2 ON m.away_team_id = t2.id
  WHERE ";

switch($args["type"])
   {
    case "home":
          $query .= "home_team_id = :home_team_id 
    AND ";
        break;
        case "away":
            $query .= "away_team_id = :away_team_id AND ";
        break;
        default:
            $query .= "(home_team_id = :home_team_id OR away_team_id = :away_team_id) AND ";
        break;
      }

      $query .= "round_id = :round_id";

      $sql = $this->db->prepare($query);
      $sql->bindParam("home_team_id", $args["team_id"]);
      $sql->bindParam("away_team_id", $args["team_id"]);
      $sql->bindParam("round_id", $args["round_id"]);
      $sql->execute();

      $result = $sql->fetchAll();
      return $response->withJson($result);
    });

Solution

  • yours:

     $sql->bindParam("team_id", $args["team_id"]);
     $sql->bindParam("round_id", $args["round_id"]);
    

    try this, the params might be needed to be formatted differently

    $sql->bindParam(":team_id", $args["team_id"], PDO::PARAM_INT);
    $sql->bindParam(":round_id", $args["round_id"], PDO::PARAM_INT);
    

    or

    $sql->bindParam(":team_id", $args["team_id"]);
    $sql->bindParam(":round_id", $args["round_id"]);