Search code examples
javaandroidsqliteandroid-memory

OutOfMemoryError when setting Uri with setImageURI


The user select a image, the path of the image is then stored in my SQLite database. I then populate the text/images from SQLite in a GridView using a CursorAdapter:

public class MyNiftyAdapter extends CursorAdapter{
private LayoutInflater mInflater;
private Cursor cur;

public MyNiftyAdapter(Context context, Cursor c) {
    super(context,c);
    this.mInflater = LayoutInflater.from(context);
    this.cur = c;
}
public MyNiftyAdapter(Context context, Cursor c, boolean autoRequery)
{
    super(context, c, autoRequery);
    this.mInflater = LayoutInflater.from(context);
    this.cur = c;
}
@Override
public View getView(int position, View convertView, ViewGroup parent)
{
    ViewHolder viewHolder;
    if(convertView == null)
    {
        convertView = this.mInflater.inflate(R.layout.single_item, null);
        viewHolder = new ViewHolder();
        viewHolder.name = (TextView)convertView.findViewById(R.id.txtName);
        viewHolder.Age = (TextView)convertView.findViewById(R.id.studentage);
        viewHolder.Id = (TextView)convertView.findViewById(R.id.rowid);
        viewHolder.Image = (CircularImageView)convertView.findViewById(R.id.imgFood);
        convertView.setTag(viewHolder);
    }else
    {
        viewHolder = (ViewHolder)convertView.getTag();
    }
    this.cur.moveToPosition(position);

    viewHolder.name.setText(this.cur.getString(this.cur.getColumnIndex(SQLiteHelper.NAME)));
    viewHolder.Age.setText(this.cur.getString(this.cur.getColumnIndex(SQLiteHelper.AGE)));
    viewHolder.Id.setText(this.cur.getString(this.cur.getColumnIndex(SQLiteHelper._ID)));
    Uri jg = Uri.parse(this.cur.getString(this.cur.getColumnIndex("imagepath")));
    viewHolder.Image.setImageURI(jg);

    return convertView;
}

@Override
public void bindView(View view, Context context, Cursor cursor) {

}

@Override
public View newView(Context context, Cursor cursor, ViewGroup parent) {
    // Dont need to do anything here
    return null;
}

static class ViewHolder
{
    TextView name;
    TextView Age;
    TextView Id;
    CircularImageView Image;
}
}

When I select large images I get a out of memory error:

java.lang.OutOfMemoryError: Failed to allocate a 21566748 byte allocation with 8448604 free bytes and 8MB until OOM

I have seen that the bitmap should be scaled down, but I'm just using the Uri of the file and displaying it. Is there anyway to avoid this issue as I don't want to save another(compressed) file to the device?

I have tried android:hardwareAccelerated="false" in manifest.


This is what worked for me:

I ended up using picasso as the answers suggested, but something important to note is that when loading a URI from device is to load the URI like this:

Picasso.with(mContext)
            .load(new File(String.valueOf(Uri)))
            .placeholder(R.drawable.profile)
            .resize(800, 800)
            .centerCrop()
            .into(viewHolder.Image);

note that I used .load(new File(String.valueOf(Uri))) instead of .load(uri). If you load the URI directly the view will return empty.

If you load a image from a url, it should be loaded like this:

Picasso.with(mContext)
            .load(URL)
            .placeholder(R.drawable.profile)
            .resize(800, 800)
            .centerCrop()
            .into(viewHolder.Image);

So my adapter ended up looking like this:

public class MyNiftyAdapter extends CursorAdapter{
private LayoutInflater mInflater;
private Cursor cur;
private Context mContext;

public MyNiftyAdapter(Context context, Cursor c) {
    super(context,c);
    this.mInflater = LayoutInflater.from(context);
    this.mContext = context;
    this.cur = c;
}
public MyNiftyAdapter(Context context, Cursor c, boolean autoRequery)
{
    super(context, c, autoRequery);
    this.mInflater = LayoutInflater.from(context);
    this.cur = c;
    this.mContext = context;
}
@Override
public View getView(int position, View convertView, ViewGroup parent)
{
    ViewHolder viewHolder;
    if(convertView == null)
    {
        convertView = this.mInflater.inflate(R.layout.single_item, null);
        viewHolder = new ViewHolder();
        viewHolder.name = (TextView)convertView.findViewById(R.id.txtName);
        viewHolder.Age = (TextView)convertView.findViewById(R.id.studentage);
        viewHolder.Id = (TextView)convertView.findViewById(R.id.rowid);
        viewHolder.Image = (CircularImageView)convertView.findViewById(R.id.imgFood);
        convertView.setTag(viewHolder);
    }else
    {
        viewHolder = (ViewHolder)convertView.getTag();
    }
    this.cur.moveToPosition(position);

    viewHolder.name.setText(this.cur.getString(this.cur.getColumnIndex(SQLiteHelper.NAME)));
    viewHolder.Age.setText(this.cur.getString(this.cur.getColumnIndex(SQLiteHelper.AGE)));
    viewHolder.Id.setText(this.cur.getString(this.cur.getColumnIndex(SQLiteHelper._ID)));
    Uri jg = Uri.parse(this.cur.getString(this.cur.getColumnIndex("imagepath")));

    Picasso.with(mContext)
            .load(new File(String.valueOf(jg)))
            .placeholder(R.drawable.profile)
            .resize(800, 800)
            .centerCrop()
            .into(viewHolder.Image);

    return convertView;
}

@Override
public void bindView(View view, Context context, Cursor cursor) {

}

@Override
public View newView(Context context, Cursor cursor, ViewGroup parent) {
    // Dont need to do anything here
    return null;
}

static class ViewHolder
{
    TextView name;
    TextView Age;
    TextView Id;
    CircularImageView Image;
}
}

Thank you all for the help.


Solution

  • You can use Picasso library to display images.

    compile 'com.squareup.picasso:picasso:2.5.2'
    

    And in your adapter something like this :

    Uri jg = Uri.parse(this.cur.getString(this.cur.getColumnIndex("imagepath")));
    Picasso.with(context).load(jg).into(viewHolder.Image);