Search code examples
javascriptd3.jspie-chart

Getting "Error, too late " for D3 transition


I am trying to do three transitions in onClick event of a Pie Chart. The first transition works but the second and the third one fail. I understood from Mike Bostocks comment on a similar question that "This means you are trying to modify a transition that has already started, or derive a transition from one that has ended. Please read the API Reference section on transition life cycles."

I still cant seem to understand the reason why this is happening. Here is the relevant code:

self.primaryLabelText = self.arc.append("text")
    .on("click", function (d: any) {
        console.log("About to send::::" + getStudyLabel(d.index));
        self.selectedIndustryTypeService.sendMessage(getStudyLabel(d.index));
        self.showDialog();

        // The amount we need to rotate:
        var rotate = 180-(d.startAngle + d.endAngle)/2 / Math.PI * 180;

        // Transition the pie chart
        g.transition()
            .attr("transform",  "translate(" + self.width / 2 + "," + self.height / 2 + ") rotate(" + rotate + ")")
            .duration(1000);

        // Τransition the labels:
        self.primaryLabelText.transition()
            .attr("transform", function(dd: any) {
            return "translate(" + label.centroid(dd) + ") rotate(" + (-rotate) + ")"; })
            .duration(1000);

        self.secondaryLabelText.transition()
            .attr("transform", function(dd: any) {
            return "translate(" + label.centroid(dd) + ") rotate(" + (-rotate) + ")"; })
            .duration(1000);

    })
    .transition()
    .duration(750)
    .attr("transform", function (d: any) {
        return "translate(" + label.centroid(d) + ")";
    })
    .attr("dy", "-0.75em")
    .attr("font-family", "sans-serif")
    .attr("font-size", "15px")
    .attr("text-anchor", "middle")
    .attr("class", "sponsor-pie-widget-label")
    .text(function (d: any) {
        if (d.endAngle - d.startAngle < 0.3) {
            return "";
        } else {
            return getStudyLabel(d.index);
        }
    });

What is the issue here?


Solution

  • The problem was that the primaryLabel and secondaryLabel I was trying to do transition on were not assigned correctly. I had the following assignment:

    self.primaryLabelText = self.arc.append("text")
        .on("click", function (d: any) {
            self.rotateChart(d);
        }).transition()
        .duration(750)
        .attr("transform", function (d: any) {
            return "translate(" + self.label.centroid(d) + ")";
        })
        .attr("dy", "-0.75em")
        .attr("font-family", "sans-serif")
        .attr("font-size", "15px")
        .attr("text-anchor", "middle")
        .attr("class", "sponsor-pie-widget-label")
        .text(function (d: any) {
            if (d.endAngle - d.startAngle < 0.3) {
                return "";
            } else {
                return getStudyLabel(d.index);
            }
        });
    

    As a result of this, the variables contained the reference to the transitions and not the labels themselves as when you chain transitions it gets changed to a transition type object. So I changed that to this:

    self.primaryLabelText = self.arc.append("text")
        .on("click", function (d: any) {
            self.rotateChart(d);
        });
    
    self.primaryLabelText.transition()
        .duration(750)
        .attr("transform", function (d: any) {
            return "translate(" + self.label.centroid(d) + ")";
        })
        .attr("dy", "-0.75em")
        .attr("font-family", "sans-serif")
        .attr("font-size", "15px")
        .attr("text-anchor", "middle")
        .attr("class", "sponsor-pie-widget-label")
        .text(function (d: any) {
            if (d.endAngle - d.startAngle < 0.3) {
                return "";
            } else {
                return getStudyLabel(d.index);
            }
        });
    

    It all works now! :)