org.hibernate.PersistentObjectException: detached entity passed to persist: com.xptraining.model.Representative

Question

Error

  Caused by: org.hibernate.PersistentObjectException: detached entity passed to persist: com.xptraining.model.Representative

cart controller class

    @POST
    @Path(XpConstants.PLACE_ORDER)
    @Consumes("application/json")
    @Produces("application/json")
    public Status placeOrder1(Carts carts) {

        Representative r2 = carts.getRepresentative();
        List<Sku> sList = carts.getListSku();
        CartsOrderDto cartOrderDto = new CartsOrderDto();
        Sku s = new Sku();
        try {
            cartOrderDto.setCartId(carts.getCartId());
            cartOrderDto.setTotalBill(carts.getPrize());
            cartOrderDto.setProductList(carts.getListSku());
            cartOrderDto.setRepresentative(carts.getRepresentative());

            Carts c = new Carts();
            c.setCartId(carts.getCartId());
            cartServices.deleteCart(carts.getCartId());
            for (Sku sku : sList) {
                s.setPrize(sku.getPrize());
                s.setProduct(sku.getProduct());
                s.setQuanity(sku.getQuanity());
                s.setSize(sku.getSize());
                s.setSkuId(sku.getSkuId());
                s.setSkuName(sku.getSkuName());
                s.setUnitName(sku.getUnitName());
                skuServices.addSku(s);
            }
            Orders orders = new Orders();
            orders.setCurrentDate(Utilities.getTodaysDate());
            orders.setStatus("Active");
            orders.setRepresentative(r2);
            orders.setListSku(sList);

            representativeServices.addRepresentative(r2);
            orderServices.saveOrders(orders);

            logger.info("Record saved in order and deleted from cart sucessfully");
            return new Status(1, XpConstants.RECORD_SAVED);

        } catch (Exception e) {
            logger.error(XpConstants.ERROR_OCCURED, e);

        }

        return new Status(1, XpConstants.PLACED_WRONG_ID);

    }

Entity classes :

Cart.java

@Entity
@Table(name = "carts")
public class Carts {
    @Id
    @Column(name = CARTS_ID)
    private long cartId;

    @Column(name = PRIZE)
    private int prize;


    @ElementCollection(targetClass=Product.class)
    @OneToMany(cascade = CascadeType.ALL , fetch=FetchType.EAGER )
    @JoinTable(
            name = "CARTS_SKU",
            joinColumns = {  @JoinColumn(name = CARTS_ID) },
            inverseJoinColumns = { @JoinColumn(name = SKU_ID) }
    )
    private List<Sku> listSku;


    @OneToOne(cascade=CascadeType.ALL ,fetch=FetchType.EAGER)
    @JoinColumn(name=REPRESENTATIVE_ID)
    private Representative representative;

}

Orders.java

@Entity
@Table(name = Orders.TABLE_NAME)
public class Orders {

    @Id
    @GeneratedValue(strategy = GenerationType.AUTO)
    @Column(name = Order.ORDER_ID)
    private long ordersId;

    @Column(name = CURRENT_DATE)
    private Date currentDate;

    @Column(name = STATUS)
    private String status;

    @OneToOne(cascade = CascadeType.ALL, fetch = FetchType.EAGER)
    @JoinColumn(name = REPRESENTATIVE_ID)
    private Representative representative;

    @LazyCollection(LazyCollectionOption.FALSE)
    @ElementCollection(targetClass = Product.class)
    @OneToMany(cascade = CascadeType.ALL)
    @JoinTable(name = "ORDERS_SKU",
    joinColumns = { @JoinColumn(name = ORDER_ID) },
    inverseJoinColumns = { @JoinColumn(name = SKU_ID) })
    private List<Sku> listSku;
}

Representative.java

@Entity
@Table(name = Representative.TABLE_NAME)
public class Representative implements java.io.Serializable {   
    @Id
    @GeneratedValue (strategy=GenerationType.AUTO)
    @Column(name = REPRESENTATIVE_ID)
    private long representativeId;

    @Column(name = FIRST_NAME)
    private String representativeFirstName;

    @Column(name = LAST_NAME)
    private String representativeLastName;

    @Column(name = EMAIL)
    private String representativeEmail;

    @Column(name = PASSWORD)
    private String representativePassword;

    @Column(name = EMPID)
    private int representativeEmpId;

    @JsonIgnore
    @OneToOne(mappedBy="representative", cascade=CascadeType.PERSIST , fetch=FetchType.EAGER)
    private Orders orders;

    @JsonIgnore
    @OneToOne(mappedBy="representative", cascade=CascadeType.ALL , fetch=FetchType.EAGER)
    private Carts carts;
}

sku.java

@Entity
@Table(name = Sku.TABLE_NAME)
public class Sku implements java.io.Serializable  {

    @Id
    @Column(name = SKU_ID)
    private long skuId;

    @Column(name = SKU_NAME)
    private String skuName;

    @Column(name = UNIT_NAME)
    private String unitName;

    @Column(name = SIZE)
    private String size;

    @Column(name = PRIZE)
    private int prize;

    @Column(name = QUANTITY)
    private int quanity;


    @ManyToOne(fetch = FetchType.EAGER , cascade=CascadeType.ALL)
    @JoinColumn(name = PRODUCT_ID , nullable = false)
    private Product product;

}

Product.java

@Entity
@Table(name = Product.TABLE_NAME)
public class Product implements java.io.Serializable  {

    @Id
    @GeneratedValue (strategy=GenerationType.AUTO)
    @Column(name = PRODUCT_ID)
    private long productId;

    @Column(name = PRODUCT_NAME )
    private String productName;

    @Column(name = SPECIALITY_ID)
    private int specialtyId;

    @LazyCollection(LazyCollectionOption.FALSE)
    @ElementCollection(targetClass=Product.class)
    @OneToMany(mappedBy="product" , cascade=CascadeType.ALL)
    private List<Sku> listSkuOrders = new ArrayList<Sku>();
}

Also there are two extra tables which is created by @JoinTable annotation i e 1.carts_sku 2.orders_sku

service impl method for cart:

/**
 * Delete Cart
 * 
 * @param id
 *            cart id
 * @throws Exception
 */
@Override
@Transactional
public void deleteCart(long id) throws Exception {

    cartsRepository.delete(id);
}

service impl method for order:

@Override
@Transactional
public Orders saveOrders(Orders orders) {
    return ordersRepository.save(orders);
}

When i am deleting cart record by cart id it is deleted bt it can not be saved to the order it showing following error

    org.springframework.dao.InvalidDataAccessApiUsageException: detached entity passed to persist: com.xptraining.model.Representative; nested exception is org.hibernate.PersistentObjectException: detached entity passed to persist: com.xptraining.model.Representative

Caused by: org.hibernate.PersistentObjectException: detached entity passed to persist: com.xptraining.model.Representative

Answer 1

I think your carts in placeOrder1() is detached because it comes as a JSON request. Therefore carts.representative is also detached. You may need attach carts.representative to the session by doing for example session.merge() or entityManager.merge() (probably through a service class which has access to the session) See https://docs.jboss.org/hibernate/orm/3.5/api/org/hibernate/Session.html for other options for re-attaching.

The attachment must be done before you try to save carts.representative as part of Order