I have written a java class for my class project, and all of my methods are are void, and I basically do nothing but call the methods in my main method.
The code basically helps students manage their monthly income, in terms of rent and loan payments.
Can someone point me in the right direction as to what im doing wrong? Any advice in general in terms of coding habits?
the class code:
import java.io.*;
import java.util.*;
public class Finance{
private double rentExpenses, tuition, totalCost, totCost, rent;
private double payInput;
private boolean status, liveWithParent;
private int pay;
//totalCost=Final cost per month
//totCost=cost of tuition and rent per month
//Living with parents?
public void liveWithParents(){
Scanner in=new Scanner(System.in);
System.out.println("Are you living with your parents?");
String parents= in.nextLine();
if(parents.charAt(0)=='y' || parents.charAt(0)=='Y'){
status=true;}
else{
status=false;}}
//If yes, do you pay them rent?, if yes how much? else -, else How much is your monthly rent anyway?
public void amountRent(){
double rent;
char valid;
String validIn;
Scanner in=new Scanner(System.in);
if(status){
System.out.println("Do you need to pay them rent?");
validIn=in.nextLine();
valid= validIn.charAt(0);
if(valid=='y' || valid=='Y'){
System.out.println("How much is your rent?");
rent=in.nextDouble();}}
else{
System.out.println("How much is your monthly rent?");
rent=in.nextDouble();}}
//What is your college tuition, $/term
public void collegeTuition(){
System.out.println("What what is your college tuition in $ per term?");
Scanner in=new Scanner(System.in);
tuition= in.nextDouble();}
//Total cost of tuition and rent per month
public void getMonthlyCost(){
totCost= rentExpenses + tuition/3.75;
System.out.println("Your rent expenses and college tuition are: $"+totCost+" per month");}
//Method of paying for expenses
public void payMethod(){
Scanner in=new Scanner(System.in);
System.out.println("How will you pay for your expenses?"
+ "\n 1 -Savings\n 2 -Loans\n 3 -Freelance Work");
pay=in.nextInt();
while(pay<=0 || pay>3){
System.out.println("You need to enter a number coresponding to the three choiches.\n\t Try again:");
System.out.println("How will you pay for your expenses?"
+ "\n 1 -Savings\n 2 -Loans\n 3 -Freelance Work");
pay=in.nextInt();}}
//Gets the amount of savings the user has and converts
//that value to a monthly value
public void inputPayMethod(){
Scanner in=new Scanner(System.in);
if(pay==1){
System.out.println("What amount of savings do you have in total for the school year?");
payInput=in.nextDouble();
payInput=payInput/9;}
else if(pay==2){
System.out.println("What amount of loans did you acquire for this school year?");
payInput=in.nextDouble();
payInput=payInput/9;}
else if(pay==3){
System.out.println("How much revenue does your Freelane business get per month?");
payInput=in.nextDouble();}}
//Calculates the total cost that the user needs
//for renting and tuition solely
public void getTotalCost(){
totalCost=(payInput/3.75)-(rentExpenses + tuition/4.348);}
//Outputs the total cost
public void outputCost(){
System.out.println("Your balance per month after expenses is: $"
+totalCost);
if(totalCost<0){
System.out.println("You still need $"+(-totalCost)+" per months");}
if(totalCost>0){
System.out.println("In other words you should be A-O-KAY");}
//Balance calculation for an entire school year
System.out.println("For an entire school year, your expenses would be: "+
(totalCost*2));}
//Create a file with the information entered
//and the information processed
public void outputFile() throws IOException{
String payFileOutput=null;
Scanner in=new Scanner(System.in);
System.out.println("Enter the name of the file you wish to store this"+
"information in: ");
String fileName= in.nextLine();
PrintWriter file= new PrintWriter(fileName);
file.println("Your rent expenses are :"+rentExpenses);
file.println("Your college tuition in dollars per month is:"+tuition);
file.println(" -----");
file.println("Your rent expenses and college tuition are :"+(rentExpenses + tuition));
if(pay==1)
payFileOutput="Savings";
else if(pay==2)
payFileOutput="Loans";
else if(pay==3)
payFileOutput="Freelance Work";
else
;
file.println("\n\nYou choose "+payFileOutput+"as your income source");
file.println("Your balance per month after expenses is: $"+totalCost);
if(totalCost<0){
file.println("You still need $"+(-totalCost)+"per month");}
if(totalCost>0){
file.println("\n\n\nYour budget seems good");}
file.close();
System.exit(0);}
}
//The main method:
import java.io.*;
public class UseClass {
/**
* @param args
*/
public static void main(String[] args) throws IOException{
Finance fin=new Finance();
fin.liveWithParents();
fin.amountRent();
fin.collegeTuition();
fin.getMonthlyCost();
fin.payMethod();
fin.inputPayMethod();
fin.getTotalCost();
fin.outputCost();
fin.outputFile();
}
}
Thank you
The first thing that comes to mind is you need to separate your concerns. This means your Finance class should only do things related to finance. It should not do things like read input from the command line.
A way to achieve this separation would be to create another class, something like FinanceDataReader or something, and have it manage all the user interactions. It would get the data from the command line and feed it to your Finance instances. If you really wanted to get fancy, you create an interface for reading finance data, and then have a CommandLineFinanceDataReader implementation. That way you could change how you get data in the future, and not have to change your Finance class.
So, to say it another way, move any functionality that reads input into another class, to make Finance smaller and more maintainable. Build up classes that encapsulate all your functionality, but group them according to the concerns you are addressing.
Another big thing you can do is use a framework like JUnit to unit test your code. It will take an upfront investment, but it will help you save time, because you will test all the small bits as you go. In other words, you wont write 300 lines of code and then have to figure out why its not working; testing as you write each method will help you ensure your methods/classes are doing what you want.
Don't worry, this sort of things comes with time -- if this is for your first Java and possibly OO class, you will make mistakes and have limited design. That will improve with time if you stick with it.