Multiplying Pixel Values in BufferedImage results in strange Behaviour

Question

I am currently working on a program to help photographers with the creation of timelapses. It calculates an decline or rise in brightness over a series of images. So the change in Exposure and iso for example dont affect the overall decline in brightness.

For this i use a simple Swing-based Interface which displays the first and last image. Under them are sliders to adjust the Brightness of the image.

This is applied via a direct manipulation of the BufferedImages underlying DataBuffer.

Mostly this works but i encountered some images which seem to have kind of a problem.

Do you have an idea why this is happening?

public BufferedImage getImage(float mult){
    BufferedImage retim;
    retim =  new BufferedImage(img.getWidth(), img.getHeight(), img.getType());
    Graphics g = retim.getGraphics();
    g.drawImage(img, 0, 0, null);
    g.dispose();

    DataBufferByte db = (DataBufferByte) retim.getRaster().getDataBuffer();
    byte[] bts = db.getData();
    for(int i=0;i<bts.length;i++){
        float n = bts[i]*mult;
        if(n > 255){
            bts[i]= (byte) 255;
        }else{
            bts[i] = (byte) n;
        }
    }
    return retim;
}

This is the method which takes an float and multiplies every pixel in the image with it. (And some code to prevent the byte values from overflowing).

This is the unwanted behaviour (on the left) and the expected on the right.

Answer 1

Your problem is this line, and it occurs due to the fact that Java bytes are signed (in the range [-128...127]):

float n = bts[i] * mult;

After the multiplication, your n variable may be negative, thus causing the overflow to occur.

To fix it, use a bit mask to get the value as an unsigned integer (in the range [0...255]), before multiplying with the constant:

float n = (bts[i] & 0xff) * mult;

---

A better fix yet, is probably to use the RescaleOp, which is built to do brightness adjustments on BufferedImages.

Something like:

public BufferedImage getImage(float mult) {
    return new RescaleOp(mult, 0, null).filter(img, null);
}