Search code examples
javascriptsvgtranslate-animation

moving SVG 'g' tag using JavaScript


I know SVG <g> tag is not having X and Y Attributes, and the only way to transfer it is using transform like transform="translate(x,y)" and transform="rotate(45 50 50)"

I'm trying to do the same programmable using JavaScript where I want to move a g tag having a combination of rect and text, below is my code, so what mistake I've so the g is not moving / translating once i click it?

var NS="http://www.w3.org/2000/svg";     
var SVG=function(h,w){
    var svg=document.createElementNS(NS,"svg");
    svg.width=w;
    svg.height=h;
return svg;
}
var svg=SVG(1200,1500);
document.body.appendChild(svg);

class myRect {
  constructor(x,y,h,w,fill,name) {
   this.g= document.createElementNS(NS,"g");
   this.name=name;
   this.SVGObj= document.createElementNS(NS,"rect");
   self = this.SVGObj;
      self.x.baseVal.value=x;
      self.y.baseVal.value=y;
      self.width.baseVal.value=w;
      self.height.baseVal.value=h;
      self.style.fill=fill;
      
    this.text = document.createElementNS(NS, 'text');
    this.text.setAttribute('x', x+10);
    this.text.setAttribute('y', y+20);
    this.text.setAttribute('fill', '#000');
    this.text.textContent = '2';
    
    this.g.appendChild(self);
    this.g.appendChild(this.text)
    
    this.g.addEventListener("click",this,false);
  }
}

Object.defineProperty(myRect.prototype, "node", {
get: function node() {
    return this.g; // this.SVGObj;
}
});

myRect.prototype.handleEvent= function(evt){
self = this.g;
  switch (evt.type){
    case "click":
       // alert(this.name); // this.animate();    
       if (typeof self.moving == 'undefined' || self.moving == false) self.moving = true;
       else self.moving = false;
 
     if(self.moving == true)
       self.move = setInterval(()=>this.animate(),100);
       else{
       clearInterval(self.move); 
       self.parentNode.removeChild(self);
       }        
    break;
    default:
    break;
 }
}  

myRect.prototype.animate = function() {
       self = this.g;
       self.transform="translate(200,200)";
       //    self.x.baseVal.value+=1;
       //    self.y.baseVal.value+=1;
};

    var r= new myRect(50,50,30,30,'#'+Math.round(0xffffff * Math.random()).toString(16),'this is my name');
    svg.appendChild(r.node);

UPDATE I tried self.setAttribute('transform','translate(10,10)') but did not work, I was able to make ONE step ONE time only move using the self.setAttribute('transform','translate(10,10)'); where getItem(0) gets the first element in a transform attribute e.g. transform="translate(1, 1) scale(2)" where getItem(0) gets the translate(1, 1) matrix and getItem(1) gets the scale(2) as explained here

But this is still not what I need, I need continuous movement once I click the g till the loop is over.


Solution

  • Thanks to Mike Williamson, I was able to solve it developing a customs transform function:

    myRect.prototype.step = function(x,y) {
      return svg.createSVGTransformFromMatrix(svg.createSVGMatrix().translate(x,y));
    }
    

    and call it by:

    myRect.prototype.animate = function() {
       self = this.g;
       self.transform.baseVal.appendItem(this.step(1,1));
    };
    

    The full code, for any one interested, is:

    var NS="http://www.w3.org/2000/svg";  
    var SVG=function(el){
       return document.createElementNS(NS,el);
    }
    
    var svg = SVG("svg");
        svg.width='100%';
        svg.height='100%';
    document.body.appendChild(svg);
    
    class myRect {
         constructor(x,y,h,w,fill,name) {
         this.g= SVG("g");
         this.name=name;
         this.SVGObj= SVG('rect'); // document.createElementNS(NS,"rect");
            self = this.SVGObj;
            self.x.baseVal.value=x;
            self.y.baseVal.value=y;
            self.width.baseVal.value=w;
            self.height.baseVal.value=h;
            self.style.fill=fill;
            self.onclick="click(evt)";
    
    this.text = SVG('text');
    this.text.setAttribute('x', x+10);
    this.text.setAttribute('y', y+20);
    this.text.setAttribute('fill', '#000');
    this.text.textContent = name;
    
    this.g.appendChild(self);
    // this.g.appendChild(this.text); // if required to be loaded from start up
    
    this.g.addEventListener("click",this,false);
    //(e)=>alert(e.target.parentNode.parentNode); / this is to check what is clicked
      }
    }
    
    Object.defineProperty(myRect.prototype, "node", {
       get: ()=> return this.g;
    });
    
    myRect.prototype.handleEvent= function(evt){
      self = evt.target.parentNode;  // this returns the `g` element
      switch (evt.type){
          case "click":   
              if (typeof self.moving == 'undefined' || self.moving == false) self.moving = true;
              else self.moving = false;
    
     if(self.moving == true){
     self.move = setInterval(()=>this.animate(),100);
     self.appendChild(this.text); // show the text node
    
     }
    
      else{
       clearInterval(self.move);
       self.removeChild(self.childNodes[1]); // remove the text node
     //  self.parentNode.removeChild(self);  // This removes the `g` element completly
      }        
    break;
       default:
       break;
     }
    }  
    
     myRect.prototype.step = function(x,y) {
        return svg.createSVGTransformFromMatrix(svg.createSVGMatrix().translate(x,y));
     }
    
     myRect.prototype.animate = function() {
       self = this.g;
       self.transform.baseVal.appendItem(this.step(1,1));
     };
    
     for (var i = 0; i < 10; i++) {
       var x = Math.random() * 100,
           y = Math.random() * 300;
      var r= new myRect(x,y,10,10,'#'+Math.round(0xffffff * Math.random()).toString(16),'click to stop');
       svg.appendChild(r.node);
      }
    

    it is also available at JSFiddle