Search code examples
c#web-applicationsc#-2.0application-designprogrammers-notepad

how to create login with using binary files system


i have used this code but not successes. can u give me solution or can u give me different way of coding it big help to improve my knowledge.

public void button1_Click(object sender, EventArgs e) {
  string s;
  string[] ss = s.Split(':');
  using (StreamReader reader = new StreamReader("UserFile.txt")) {
    s = reader.ReadLine();
  }

  if (txtUser.Text == ss[0]) {
    if (txtPass.Text == ss[1]) {
      this.Hide();
      Properties.Settings.Default.ss = txtUser.Text;
      Properties.Settings.Default.Save();
      frmMainMenu mf = new frmMainMenu();
      mf.Show();
    }
    else {
      MessageBox.Show("Sorry Wrong Password");
    }
  }
  else {
    MessageBox.Show("Sorry Wrong Username");
  }        
}

Solution

  • Put all your checking logic inside the stream reader

    public void button1_Click(object sender, EventArgs e)
        {
    
            using (StreamReader reader = new StreamReader("UserFile.txt"))
            {
               string s;
               s = reader.ReadLine();
               string[] ss = s.Split(':');
               if (txtUser.Text == ss[0])
               {
                 if (txtPass.Text == ss[1])
                 {
                    this.Hide();
                    Properties.Settings.Default.ss = txtUser.Text;
                    Properties.Settings.Default.Save();
                    frmMainMenu mf = new frmMainMenu();
                    mf.Show();
                 }
                 else
                 {
                    MessageBox.Show("Sorry Wrong Password");
                 }
               }  
               else
               {
                 MessageBox.Show("Sorry Wrong Username");
               }
            }
    
       }