Search code examples
javaswingjtextpanejava-6

How to correctly remove the automatically added closing bracket when it is typed


in the textPaneKeyTyped(java.awt.event.keyEvent evt) method I wrote some code to automatically close brackets when the opening one is typed. I added some code for remove the closing bracket when the user type it in textPane, but it doesn't do anything

This is a working example:

package test;

import java.awt.event.ActionEvent;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.swing.AbstractAction;
import javax.swing.Action;
import javax.swing.JTextPane;
import javax.swing.KeyStroke;
import javax.swing.text.BadLocationException;


public class NewJFrame extends javax.swing.JFrame {

    /** Creates new form NewJFrame */
    public NewJFrame() {
        initComponents();
    }

    /** This method is called from within the constructor to
     * initialize the form.
     * WARNING: Do NOT modify this code. The content of this method is
     * always regenerated by the Form Editor.
     */
    @SuppressWarnings("unchecked")
    // <editor-fold defaultstate="collapsed" desc="Generated Code">
    private void initComponents() {

        jPanel1 = new javax.swing.JPanel();
        jScrollPane1 = new javax.swing.JScrollPane();
        textPanel = new javax.swing.JTextPane();

        setDefaultCloseOperation(javax.swing.WindowConstants.EXIT_ON_CLOSE);

        textPanel.addKeyListener(new java.awt.event.KeyAdapter() {
            public void keyTyped(java.awt.event.KeyEvent evt) {
                textPanelKeyTyped(evt);
            }
        });
        jScrollPane1.setViewportView(textPanel);

        javax.swing.GroupLayout jPanel1Layout = new javax.swing.GroupLayout(jPanel1);
        jPanel1.setLayout(jPanel1Layout);
        jPanel1Layout.setHorizontalGroup(
            jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(jPanel1Layout.createSequentialGroup()
                .addContainerGap()
                .addComponent(jScrollPane1, javax.swing.GroupLayout.DEFAULT_SIZE, 380, Short.MAX_VALUE)
                .addContainerGap())
        );
        jPanel1Layout.setVerticalGroup(
            jPanel1Layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING)
            .addGroup(jPanel1Layout.createSequentialGroup()
                .addGap(19, 19, 19)
                .addComponent(jScrollPane1, javax.swing.GroupLayout.PREFERRED_SIZE, 254, javax.swing.GroupLayout.PREFERRED_SIZE)
                .addContainerGap(27, Short.MAX_VALUE))
        );

        getContentPane().add(jPanel1, java.awt.BorderLayout.CENTER);

        pack();
    }// </editor-fold>

private void textPanelKeyTyped(java.awt.event.KeyEvent evt) {
// TODO add your handling code here:
     Action action1 = new AbstractAction() {

        @Override
        public void actionPerformed(ActionEvent e) {
            textModel = (JTextPane) e.getSource();
            try {
                int position2 = textModel.getCaretPosition();
                textModel.getDocument().remove(position2, 1);
                textModel.getDocument().insertString(position2, ")", null);

            } catch (Exception e1) {}
        }

};
    Action action = new AbstractAction() {

            @Override
            public void actionPerformed(ActionEvent e) {
                int position = textModel.getCaretPosition();
                textModel.replaceSelection("()");
                textModel.setCaretPosition(position+1);
            }

    };

    String key =  "typed (";
    String key1 = "typed )";
    textPanel.getInputMap().put(KeyStroke.getKeyStroke(key), key);
    textPanel.getInputMap().put(KeyStroke.getKeyStroke(key1), key1);
    textPanel.getActionMap().put(key, action);
    textPanel.getActionMap().put(key1, action1);


}

    /**
     * @param args the command line arguments
     */
    public static void main(String args[]) {
        /* Set the Nimbus look and feel */
        //<editor-fold defaultstate="collapsed" desc=" Look and feel setting code (optional) ">
        /* If Nimbus (introduced in Java SE 6) is not available, stay with the default look and feel.
         * For details see http://download.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html 
         */
        try {
            for (javax.swing.UIManager.LookAndFeelInfo info : javax.swing.UIManager.getInstalledLookAndFeels()) {
                if ("Nimbus".equals(info.getName())) {
                    javax.swing.UIManager.setLookAndFeel(info.getClassName());
                    break;
                }
            }
        } catch (ClassNotFoundException ex) {
            java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        } catch (InstantiationException ex) {
            java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        } catch (IllegalAccessException ex) {
            java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        } catch (javax.swing.UnsupportedLookAndFeelException ex) {
            java.util.logging.Logger.getLogger(NewJFrame.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        }
        //</editor-fold>

        /* Create and display the form */
        java.awt.EventQueue.invokeLater(new Runnable() {

            public void run() {
                new NewJFrame().setVisible(true);
            }
        });
    }
    // Variables declaration - do not modify
    private javax.swing.JPanel jPanel1;
    private javax.swing.JScrollPane jScrollPane1;
    private javax.swing.JTextPane textPanel;
    // End of variables declaration
}

The code for the automatic closure of the brackets works.. The problem is for the replace of the closing bracket: it prints ')' just when before there's a '('. If I would be able to print the ')' at any time, how should I edit my code? Thank you.


Solution

  • It is never a good idea to block the usage of a KeyStroke. You never know when the ")" might need to be entered manually. Who cares if the user enters the ")". If it is not syntactically correct then they will eventually get a compile error. The smart user will realize that all then need to do is type "(" and the ")" will be entered for them.

    However, if there is a situation when you do want to prevent the typing of a given character you would use Key Bindings NOT a KeyListener.

    For example:

    KeyStroke ignore = KeyStroke.getKeyStroke(')');
    textPane.getInputMap().put(ignore, "none");
    

    For more information on Key Bindings read the Swig tutorial. I gave you a link in one of your previous questions. Keep the tutorial link handy for the basics. You will find a section on How to Use Key Bindings when you look at the table of contents ("trail") for the tutorial.

    Also for your "(" Action you can just use:

    textPane.replaceSelection("()");