Search code examples
phpmysqlpdoinsert-into

PHP insert into a table not working


I'm trying to insert items into a table but it isn't working although it's displaying a successful message :/

Here's my code & table.

<?php 
    ini_set("log_errors", 1);
    ini_set("error_log", "error.log");
    error_log( "Hello, errors!" );

        $itemName = $_POST['itemName'];
        $itemDesc = $_POST['itemDesc'];
        $itemSlutID = $_POST['itemSlutID'];

            if (isset($_POST['addBtn'])){

                if (empty($itemName) || empty($itemDesc) || empty($itemSlutID)){
                    echo error('Please fill in all fields');

                }else{
                    $SQLinsert = $odb -> prepare("INSERT INTO `items` VALUES(NULL, :userID, :itemName, :itemDesc, :itemSlutID)");
                    $SQLinsert -> execute(array(':userID' => $_SESSION['ID'], ':itemName' => $itemName, ':itemDesc' => $itemDesc, ':itemSlutID' => $itemSlutID));
                    echo success('Item has been added, please wait up to 1 hour for us to approve the item.');
                }
            }
?>

CREATE TABLE `items` (
  `ID` int(11) NOT NULL,
  `userID` int(11) NOT NULL,
  `itemName` text NOT NULL,
  `itemDesc` text NOT NULL,
  `itemSlutID` text NOT NULL
) ENGINE=MyISAM DEFAULT CHARSET=latin1;

Solution

  • 1. null

    Look at your first column:

    ID int(11) NOT NULL,

    Yet your first placeholder value is NULL. Better practice would be to change it to NULL AUTO_INCREMENT.

    2. Saying "success" whatever happens

    After the statement executes, you're not checking to see if it was successful - you're just echoing a statement.

    Change:

    $SQLinsert -> execute(array(':userID' => $_SESSION['ID'], ':itemName' => $itemName, ':itemDesc' => $itemDesc, ':itemSlutID' => $itemSlutID));
    echo success('Item has been added, please wait up to 1 hour for us to approve the item.');
    

    To:

    if($SQLinsert -> execute(array(':userID' => $_SESSION['ID'], ':itemName' => $itemName, ':itemDesc' => $itemDesc, ':itemSlutID' => $itemSlutID))){
        echo success('Item has been added, please wait up to 1 hour for us to approve the item.');
    } else {
        //There's been a problem!
        echo "ERROR: " . $SQLinsert->errorInfo();
    }