How to filter out "Nothing" values from Elm Array?

I'd like to define the following function:

compactAndConvertToList : Array (Maybe String) -> List String

This function should remove all Nothing appearances in the given array, and convert it to List.

I came up with the solution below, but it feels dirty a bit.

Is there a better way to achieve this?

import Graphics.Element exposing (..)
import Array

model : Array.Array (Maybe String)
model = Array.fromList [ Just "Hello", Just "Stack", Nothing, Just "Overflow" ]


compactAndConvertToList : Array.Array (Maybe String) -> List String
compactAndConvertToList maybeStrings =
  maybeStrings
    |> Array.filter (\x -> x /= Nothing)
    |> Array.map (Maybe.withDefault "")
    |> Array.toList


main = 
  model
    |> compactAndConvertToList
    |> show

Solution

If your final result is a list, you are probably better to just convert your array to a list, and then operate on it.

import Array 

compactAndConvertToList : Array.Array (Maybe String) -> List String
compactAndConvertToList = Array.toList >> List.filterMap identity

If you're not comfortable with higher-order functions, you could write it like this:

compactAndConvertToList arr = List.filterMap identity (Array.toList arr)

We take our array, apply toList to it, then apply filterMap with it. Filter map takes a function which produces a maybe, and applies it to every element in the list, discarding the Nothing cases. We just apply the identity functions, which discards the Nothing values that are already there.

In general, Arrays are good for fast random access, but if you're traversing the entire collection a bunch of times, Lists will tend to be faster. But, always start by doing it the clear way, then optimize if you need to.