I have a list of data which I need to sort efficiently in below manner for job_status under pre_release only for object which has run: 1
"FAILED", "WARNING", "SUCCESS"
I am trying to use bubble sort, but need help
//compareData contains list of object which needs to be sorted
List<HashMap<String, Object>> compareData = new ArrayList<HashMap<String, Object>>();
HashMap<String, Object> tempObj = new HashMap<String, Object>();
for (int i=0; i<compareData.size(); i++) {
for (int j=1; i<(compareData.size() - 1); j++) {
if (Integer.parseInt(compareData.get(j-1).get(JOB_STATUS_CODE).toString()) > Integer.parseInt(compareData.get(j).get(JOB_STATUS_CODE).toString())) {
tempObj = compareData.get(j-1);
//compareData.get(j-1) = compareData.get(j);
}
}
}
compareData
[{
"pre_release": [{
"message": "The environment GYAN-WIN2008-64-SP2-DC-1 used by this connection is inactive.",
"start_time": "2015-05-27T22:45:25.000-07:00",
"run": "1",
"job_status": "FAILED",
"job_status_code": "3"
}, {
"message": "The environment GYAN-WIN2008-64-SP2-DC-1 used by this connection is inactive.",
"start_time": "2015-05-27T22:00:25.000-07:00",
"run": "2",
"job_status": "FAILED",
"job_status_code": "3"
}, {
"message": "The environment GYAN-WIN2008-64-SP2-DC-1 used by this connection is inactive.",
"start_time": "2015-05-27T21:15:25.000-07:00",
"run": "3",
"job_status": "FAILED",
"job_status_code": "3"
}],
"task_name": "DB to DB xxx.yyy.42.62_2",
"task_id": "000ABC0G000000000007",
"production": {
"message": "The environment Redhat Linux used by this connection is inactive.",
"start_time": "2015-05-21T05:50:05.000-07:00",
"job_status": "FAILED",
"job_status_code": "3"
}
} {
"pre_release": [{
"message": "The environment Redhat Linux used by this connection is inactive.",
"start_time": "2015-05-21T05:50:05.000-07:00",
"run": "1",
"job_status": "FAILED",
"job_status_code": "3"
}, {
"message": "The environment Redhat Linux used by this connection is inactive.",
"start_time": "2015-05-21T05:45:05.000-07:00",
"run": "2",
"job_status": "FAILED",
"job_status_code": "3"
}, {
"message": "The environment Redhat Linux used by this connection is inactive.",
"start_time": "2015-05-21T05:40:05.000-07:00",
"run": "3",
"job_status": "FAILED",
"job_status_code": "3"
}],
"task_name": "IPS_WS_Test",
"task_id": "000ABC0K000000000096",
"production": {
"message": null,
"start_time": "2015-02-02T13:05:00.000-08:00",
"job_status": "SUCCESS",
"job_status_code": "1"
}
}, {
"pre_release": [{
"message": null,
"start_time": "2015-02-02T13:05:00.000-08:00",
"run": "1",
"job_status": "SUCCESS",
"job_status_code": "1"
}, {
"message": null,
"start_time": "2015-02-02T13:00:00.000-08:00",
"run": "2",
"job_status": "SUCCESS",
"job_status_code": "1"
}, {
"message": null,
"start_time": "2015-02-02T12:55:00.000-08:00",
"run": "3",
"job_status": "SUCCESS",
"job_status_code": "1"
}],
"task_name": "Logan josh mct win",
"task_id": "000ABC0Z00000000009V",
"production": {
"message": "No errors encountered.",
"start_time": "2015-05-19T13:31:28.000-07:00",
"job_status": "SUCCESS",
"job_status_code": "1"
}
}, {
"pre_release": [{
"message": null,
"start_time": "2015-05-14T07:27:10.000-07:00",
"run": "1",
"job_status": "WARNINGS",
"job_status_code": "2"
}, {
"message": "Target field [MD_COntact__c] does not exist in the object [onlytesting__c].",
"start_time": "2015-05-14T07:25:25.000-07:00",
"run": "2",
"job_status": "FAILED",
"job_status_code": "3"
}, {
"message": "Target field [MD_COntact__c] does not exist in the object [onlytesting__c].",
"start_time": "2015-05-14T07:24:55.000-07:00",
"run": "3",
"job_status": "FAILED",
"job_status_code": "3"
}],
"task_name": "Lambba",
"task_id": "000ABCI0000000002XP",
"production": {
"message": null,
"start_time": "2015-05-14T07:27:10.000-07:00",
"job_status": "WARNINGS",
"job_status_code": "2"
}
}, {
"pre_release": [{
"message": "No errors encountered.",
"start_time": "2015-05-19T13:31:28.000-07:00",
"run": "1",
"job_status": "SUCCESS",
"job_status_code": "1"
}, {
"message": "No errors encountered.",
"start_time": "2015-05-19T13:12:15.000-07:00",
"run": "2",
"job_status": "SUCCESS",
"job_status_code": "1"
}, {
"message": "No errors encountered.",
"start_time": "2015-05-19T12:51:50.000-07:00",
"run": "3",
"job_status": "SUCCESS",
"job_status_code": "1"
}],
"task_name": "chahamedidata_baja2",
"task_id": "000ABC0I000000000301",
"production": {
"message": "[ERROR] com.baja.api.bajaServiceQueryOperationTimeIntervalFaultFaultFaultMessage: Query is limited to 1 request every 250 milliseconds (there have been 64.2 milliseconds since the last request)",
"start_time": "2015-05-19T13:20:05.000-07:00",
"job_status": "SUCCESS",
"job_status_code": "1"
}
}]
Update
So I did something like below, but I am getting Exception in thread "main" java.lang.IllegalArgumentException: Comparison method violates its general contract!
Collections.sort(compareData, new Comparator<HashMap<String, Object>>() {
@SuppressWarnings("unchecked")
@Override
public int compare(HashMap<String, Object> o1, HashMap<String, Object> o2) {
// TODO Auto-generated method stub
int i = 0;
ArrayList<?> firstArray = (ArrayList<?>) o1.get(PRE_RELEASE);
ArrayList<?> secondArray = (ArrayList<?>) o2.get(PRE_RELEASE);
do {
//System.out.println (((HashMap<String,Object>) firstArray.get(i)).get("run"));
if (((HashMap<String,Object>) firstArray.get(i)).get("run").equals("1")) {
if (((HashMap<String,Object>) firstArray.get(i)).get(JOB_STATUS).equals(((HashMap<String,Object>) secondArray.get(i)).get(JOB_STATUS))) {
return 0;
} else {
if (((HashMap<String,Object>) firstArray.get(i)).get(JOB_STATUS).equals("FAILED"))
return -1;
else if (((HashMap<String,Object>) firstArray.get(i)).get(JOB_STATUS).equals("WARNING")) {
return ((HashMap<String,Object>) firstArray.get(i)).get(JOB_STATUS).equals("FAILED") ? 1 : -1;
}
else {
return 1;
}
}
}
i++;
} while (i < firstArray.size());
return 0;
}
});
A comparator needs to respect the transitivity of the comparison. Meaning if a=b and b=c then a=c, and same with > and <. Your implementation is simply returning 0 in too many cases. I suggest you look into the following approach:
List<HashMap<String, Object>> compareData = new ArrayList<>();
Collections.sort(compareData, new Comparator<HashMap<String, Object>>() {
@SuppressWarnings("unchecked")
@Override
public int compare(HashMap<String, Object> o1, HashMap<String, Object> o2) {
ArrayList<?> firstArray = (ArrayList<?>) o1.get(PRE_RELEASE);
ArrayList<?> secondArray = (ArrayList<?>) o2.get(PRE_RELEASE);
Object firstRun1 = null;
for (Object firstRun : firstArray) {
if (((HashMap<String,Object>) firstRun).get("run").equals("1")) {
firstRun1 = firstRun;
break;
}
}
Object secondRun1 = null;
for (Object secondRun : secondArray) {
if (((HashMap<String,Object>) secondRun).get("run").equals("1")) {
secondRun1 = secondRun;
break;
}
}
if (firstRun1 == secondRun1) {
return 0;
}
else if (firstRun1 == null) {
return -1;
}
else if (secondRun1 == null) {
return 1;
}
else {
String firstStatus = (String) ((HashMap<String,Object>) firstRun1).get(JOB_STATUS);
String secondStatus = (String) ((HashMap<String,Object>) secondRun1).get(JOB_STATUS);
return toNum(firstStatus).compareTo(toNum(secondStatus));
}
}
});
The toNum method:
Integer toNum(String status) {
return "FAILED".equals(status) ? 0 : ("WARNING".equals(status) ? 1 : 2);
}
I am sorry I could not test it because I am lacking a few pieces of your code.
Now another advice: there are too many unchecked conversions and castings in this code. I suggest you work directly to some JSONObject that a framework might be returning to you when parsing the Json, or you map your business objects into real POJO instead of maps and lists of Objects.