Search code examples
arraysassemblyx86bubble-sort

Bubble sort on array on Assembly Language


I need to Bubblesort an unorganized array with 7 integers from biggest to smallest so it would look like 9,6,5,4,3,2,1.
I ran my code through the compiler and it says

Compiler Error

I can't understand what is the problem with this code:

code segment
assume ds:code,cs:code
start:
 mov ax,code
 mov ds,ax    ;code start
ARR:   dw 1,2,4,3,6,5,9
 mov ch,0h
 mov cl,1h
 mov bh 7h
 jmp assign_nums
restart:
 mov ch,0h
 mov cl,1h
 dec bh
 jmp assign_nums
swap:
 mov ch,dl
 mov cl,dh
 jmp next
next:
 cmp bh,cl
 je restart
 add ch,1h
 add cl,1h
 jmp assign_nums
assign_nums:
 cmp bh,0h
 je done
 mov dh,[ARR+ch]
 mov dl,[ARR+cl]
 cmp dh,dl
 jl swap
 jnl next
done:
 nop
code ends
end start

Solution

  • For the 1st error you forgot to type a comma between the register and the immediate.

    For the 2nd and 3rd errors the CH and CL registers cannot be used for addressing memory. Use SI, DI, or BX instead.

    Since your array is defined as words you must treat it as such!
    Change

    mov dh,[ARR+ch]
    mov dl,[ARR+cl]
    

    into something like (depends on other choices you make)

    mov ax,[ARR+si]
    mov dx,[ARR+di]
    

    Please note that you placed the array amidst the instructions. This will crash your program as soon as you manage to compile it. Either place the array in a separate data segment of your program or jump over this line.

    start:
     mov ax,code
     mov ds,ax
     jmp start2
    ARR:   dw 1,2,4,3,6,5,9
    start2:
     mov ch,0h