Search code examples
javaspringaopaspectj

Entity Aspect (in Spring)

I'm having a bit of a problem defining my aspects. I've got a bunch of entities that I'd like to profile the get-methods in, so I've written the following pointcut and method

@Pointcut("execution(* tld.myproject.data.entities.*.get*()")
public void getEntityProperty() {}

@Around("getEntityProperty()")
public Object profileGetEntityProperty(ProceedingJoinPoint pjp) throws Throwable {
    long start = System.currentTimeMillis();
    String name = pjp.getSignature().getName();
    Object output = pjp.proceed();
    long elapsedTime = System.currentTimeMillis() - start;
    if(elapsedTime > 100)
        System.err.println("profileGetEntityProperty: Entity method " + name + " execution time: " + elapsedTime + " ms.");
    return output;
}

I've got weaving turned on in my configuration, and aspects weaving into the business layer work just fine. Is my pointcut correctly written? Or is there something about entities that make them non-weavable? (my entity is prefixed with @Entity before the class definition)

Cheers

Nik

Solution

  • You're only a parenthesis away actually!

    @Pointcut("execution(* tld.myproject.data.entities..get())")

    If you're using Eclipse, I will recommend developing with AspectJ compile-time weaving. It's the simplest way.

    With the AJDT plugin, you get lots of help! I just pasted in your pointcut and got an compilation error. Added a parenthesis and it worked!

    Screenshot of visual support with the AJDT plugin:

    alt text

    The orange arrow to the left of the getHello() method indicates that is's advised by an around advice. See here for a larger example.