Search code examples
javaandroidonclicklisteneronlongclicklistener

onclick listener activates with onlongclick listener


here is the code. When I long click on an item and dont drag my finger away from it, the menu still pops up, but it also activates my onClick listener. I have no idea why. I have tried looking for solutions online, and I only found something that told me to check the return statement. I am returning True, so I do not know what else to do.

listView.setOnItemClickListener(new OnItemClickListener(){
        @Override
        public void onItemClick(AdapterView<?> parent, View view,
                int position, long id) {
            Toast.makeText(AddClaim.this, "Clicked "+list.get(position), Toast.LENGTH_SHORT).show();
            //adapter expenses
            setContentView(R.layout.add_expense);
            ListView expView = (ListView) findViewById(R.id.ExpenseListView);
            Collection<Expense> expenses = list.get(position).getExpenses();
            final ArrayList<Expense> expense = new ArrayList<Expense>(expenses);
            final ArrayAdapter<Expense> expAdap = new ArrayAdapter<Expense>(AddClaim.this, android.R.layout.simple_list_item_1, expense);
            expView.setAdapter(expAdap);
            }

    });

    //LONG CLICK FUNCTIONS
    listView.setOnItemLongClickListener(new OnItemLongClickListener(){
        @Override
        public boolean onItemLongClick(AdapterView<?> parent, View view,
                int position, long id) {
            final int finalPosition = position;
            PopupMenu popup = new PopupMenu(AddClaim.this, view);
            popup.getMenuInflater().inflate(R.menu.add_claim, popup.getMenu());
            popup.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() {  
                public boolean onMenuItemClick(MenuItem item) {  
                //DELETE button check.  
                  if (item.getTitle().equals("Delete")){
                    AlertDialog.Builder adb = new AlertDialog.Builder(AddClaim.this);
                    adb.setMessage("Delete "+ list.get(finalPosition).toString()+"?");
                    adb.setCancelable(true);
                    adb.setPositiveButton("Delete",new OnClickListener(){
                        @Override
                        public void onClick(DialogInterface dialog, int which) {
                            Claim claim = list.get(finalPosition);
                            ClaimListController.getClaimList().deleteClaim(claim);
                        }
                    });
                    adb.setNegativeButton("Cancel",new OnClickListener(){

                        @Override
                        public void onClick(DialogInterface dialog, int which) {                        
                        }

                    });
                    adb.show();
                  }//end of delete button check
                  //START of ADD EXPENSE check
                  if (item.getTitle().equals("Add Expense")){
                      Intent intent = new Intent(AddClaim.this, ExpenseAdd.class);
                      intent.putExtra("somename", finalPosition);
                      startActivity(intent);

                          }
                  //end of add expense check
                  return true;  
                 }  
                });  
            popup.show();
        return false;
        }

    });

}

Solution

  • Look carefully at your code,and count your braces but read my comments

    listView.setOnItemLongClickListener(new OnItemLongClickListener(){ //function starts here
        @Override
        public boolean onItemLongClick(AdapterView<?> parent, View view,
                int position, long id) { // longclick starts here
            final int finalPosition = position;
            PopupMenu popup = new PopupMenu(AddClaim.this, view); // your menu code starts here
            popup.getMenuInflater().inflate(R.menu.add_claim, popup.getMenu());
            popup.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() {  
                public boolean onMenuItemClick(MenuItem item) {  
                //DELETE button check.  
                  if (item.getTitle().equals("Delete")){
                    AlertDialog.Builder adb = new AlertDialog.Builder(AddClaim.this);
                    adb.setMessage("Delete "+ list.get(finalPosition).toString()+"?");
                    adb.setCancelable(true);
                    adb.setPositiveButton("Delete",new OnClickListener(){
                        @Override
                        public void onClick(DialogInterface dialog, int which) {
                            Claim claim = list.get(finalPosition);
                            ClaimListController.getClaimList().deleteClaim(claim);
                        }
                    });
                    adb.setNegativeButton("Cancel",new OnClickListener(){
    
                        @Override
                        public void onClick(DialogInterface dialog, int which) {                        
                        }
    
                    });
                    adb.show();
                  }//end of delete button check
                  //START of ADD EXPENSE check
                  if (item.getTitle().equals("Add Expense")){
                      Intent intent = new Intent(AddClaim.this, ExpenseAdd.class);
                      intent.putExtra("somename", finalPosition);
                      startActivity(intent);
    
                          }
                  //end of add expense check
                  return true;  // you only return true if onmenu item is clicked.. which is too late
                 }  
                });  
            popup.show();  // and your menu code ends here, because this is where it is shown..
        return false; // you are returning false.. this is {star line}
        } //longclick ends here 
    
     }); //function ends here
    
    }
    

    {start line} should return true