GitHub pull request showing commits that are already in target branch
I'm trying to review a pull request on GitHub to a branch that isn't master. The target branch was behind master and the pull request showed commits from master, so I merged master and pushed it to GitHub, but the commits and diff for them still appear in the pull request after refreshing. I've doubled checked that the branch on GitHub has the commits from master. Why are they still appearing in the pull request?
I've also checked out the pull request locally and it only shows the un-merged commits.
It looks like the Pull Request doesn't keep track of changes to the target branch (I contacted GitHub support, and received a response on 18 Nov 2014 stating this is by design).
However, you can get it to show you the updated changes by doing the following:
http://githuburl/org/repo/compare/targetbranch...currentbranch
Replace githuburl, org, repo, targetbranch, and currentbranch as needed.
Or as hexsprite pointed out in his answer, you can also force it to update by clicking Edit on the PR and temporarily changing the base to a different branch and back again. This produces the warning:
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
And will leave two log entries in the PR:
- How can I unlock my gemfile so I can access the rails server?
- How to deploy a Java web application on OpenShift or Git?
- How to Use Yarn Version command to update to released version from prerelease version
- Add Change-Id to all commits
- How can one change the timestamp of an old commit in Git?
- How do I get the hash for the current commit in Git?
- Git Ignore strangeness
- key_load_public: invalid format
- Are there any other "special git commit messages" than [skip ci]?
- limit number of commits to push on remote
- How to undo merge of master branch?
- Commit hash for git revert?
- Break a previous commit into multiple commits
- Git interactive unstage part of a file or by hunks
- local cache for a github repository?
- Git-hook to show if I've got a stash on the checked out branch
- What's the difference between HEAD, working tree and index, in Git?
- How do you stop tracking a remote branch in Git?
- Search all files of all commits in git log for specific string
- How to log first 10 commits in Git
- intended flow when git stash pop gets conflicts
- How to get default Git branch?
- Setting up SSH keys for Bitbucket on Windows
- error: pathspec 'test-branch' did not match any file(s) known to git
- git add <filename> not working
- Two different projects sharing secret.json locally
- git force push to upstream remote branch of PR
- Weird IP Address while GIT pull
- Will a git push be interrupted if my computer's internet connection is dropped temporarily?
- moving changed files to another branch for check-in