c#.netdotnetzip
.NET 3.5 DotNetZip Problems searching through extracted files
I have zip files I need to search through I have working code for .NET 4.5 using System.IO.Compression and it works flawlessly but I can't seem to get it to work using DotNetZip in .NET 3.5
Here is my code
di = new DirectoryInfo(sFullLogPath + "\\");
files = di.GetFiles(sExtension);
logs.Info("Searching " + sType + " logs on " + sDate + " for " + sSearchTerm);
Console.WriteLine("");
try
{
foreach(var file in files)
{
//Console.WriteLine(file.FullName);
using (ZipFile archive = ZipFile.Read(sFullLogPath + "\\" + file.Name))
{
foreach(var entry in archive)
{
if(entry.FileName.EndsWith(".ininlog",StringComparison.OrdinalIgnoreCase))
{
//Console.WriteLine(entry.FileName);
try
{
Directory.CreateDirectory(sTemp);
entry.Extract(Path.Combine(sTemp, entry.FileName));
Stream streamTemp = new FileStream(file.FullName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
StreamReader streamReader = new StreamReader(streamTemp);
string line;
while ((line = streamReader.ReadLine()) != null)
{
if (line.Contains(sSearchTerm))
{ logs.Info("{0} contains \"{1}\"", file.Name, sSearchTerm); break; }
else
{ Console.ForegroundColor = ConsoleColor.Red; Console.WriteLine("{0} does not contain \"{1}\"", file.Name, sSearchTerm); Console.ResetColor(); break; }
}
}
catch (UnauthorizedAccessException ae)
{
logs.Error(ae.Message);
}
catch (SystemException se)
{
logs.Error(se.Message);
}
catch (ApplicationException ape)
{
logs.Error(ape.Message);
}
catch (Exception e)
{
logs.Error(e.Message);
}
finally
{
Directory.Delete(sTemp, true);
archive.Dispose();
}
}
}
}
}
}
catch (UnauthorizedAccessException ae)
{
logs.Error(ae.Message);
}
catch (SystemException se)
{
logs.Error(se.Message);
}
catch (ApplicationException ape)
{
logs.Error(ape.Message);
}
catch (Exception e)
{
logs.Error(e.Message);
}
Expected Behavior:
Each zipped file in a directory is unzipped to a temporary location then searched to see if the string is in that file, if found it will output the name of the file it was found in
Current Behavior:
Not finding and referencing to the string I am looking for even though I know it's there and it works fine with the .NET 4.5 version on the same file
Why don't I use .NET 4.5, we have custom software on our servers and it currently has issues with .NET 4.5
Fixed code thanks to @Thomas - looks like the else was causing the false positive
else { Console.ForegroundColor = ConsoleColor.Red; Console.WriteLine("{0} does not contain \"{1}\"", file.Name, sSearchTerm); Console.ResetColor(); break; }
Here is the fixed code
di = new DirectoryInfo(sFullLogPath + "\\");
files = di.GetFiles(sExtension);
logs.Info("Searching " + sType + " logs on " + sDate + " for " + sSearchTerm);
Console.WriteLine("");
try
{
foreach(var file in files)
{
//Console.WriteLine(file.Name);
using (ZipFile archive = ZipFile.Read(file.FullName))
{
foreach(var entry in archive)
{
if(entry.FileName.EndsWith(".ininlog", StringComparison.OrdinalIgnoreCase))
{
try
{
using (var tempStream = entry.OpenReader())
using (var streamReader = new StreamReader(tempStream))
{
string line;
while ((line = streamReader.ReadLine()) != null)
{
if(line.Contains(sSearchTerm))
{
logs.Info("{0} contains \"{1}\"", file.Name, sSearchTerm);
break;
}
}
}
}
catch (UnauthorizedAccessException ae)
{
logs.Error(ae.Message);
}
catch (SystemException se)
{
logs.Error(se.Message);
}
catch (ApplicationException ape)
{
logs.Error(ape.Message);
}
catch (Exception e)
{
logs.Error(e.Message);
}
finally
{
archive.Dispose();
//Directory.Delete(sTemp + "\\" + entry.FileName);
}
}
}
}
}
}
catch (UnauthorizedAccessException ae)
{
logs.Error(ae.Message);
}
catch (SystemException se)
{
logs.Error(se.Message);
}
catch (ApplicationException ape)
{
logs.Error(ape.Message);
}
catch (Exception e)
{
logs.Error(e.Message);
}
finally
{
//
}
break;
Solution
You're opening the wrong file here:
Stream streamTemp = new FileStream(file.FullName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
file is the ZIP file, not the file you just extracted.
BTW, I don't think you need to extract the files, DotNetZip probably allows you to write the uncompressed stream directly.
EDIT: I just checked: you can use the OpenReader method to get a stream to read the uncompressed content of the entry. Just create the StreamReader around that stream; no need to actually extract the file.
...
try
{
using (var stream = entry.OpenReader())
using (var reader = new StreamReader(stream))
{
string line;
while ((line = streamReader.ReadLine()) != null)
{
if (line.Contains(sSearchTerm))
{ logs.Info("{0} contains \"{1}\"", file.Name, sSearchTerm); break; }
else
{ Console.ForegroundColor = ConsoleColor.Red; Console.WriteLine("{0} does not contain \"{1}\"", file.Name, sSearchTerm); Console.ResetColor(); break; }
}
}
}
...
- Understanding the difference in timing of two functions that increment each element of an integer array
- Why MSVC generates warning C4127 when constant is used in "while" - C
- Executing a user-space function from the kernel space
- Why must the variable used to hold getchar's return value be declared as int?
- mpirun -np 4 ./a.out doesn't use all my cores (ubuntu 24.04LTS)
- Shadowing an iterator inside a for loop has undefined (?) behaviour in C
- Sleep for N seconds and wait for keypress
- Dereference twice in gdb
- Is this declaration UB?
- return type defaults to 'int' [-Wimplicit-int]
- What is the scope of `fesetround()`?
- Which specific optimization flag causes libm functions to be treated as pure?
- How to render text in SDL2?
- Why would you use 'extern "C++"'?
- Strange Behavior Compiler Ignoring NULL Check Unless I Print Something in the if Statement
- Fast inverse square root using fixed point instead of floating point
- What is the const qualifier attached to in C: the memory area or the pointer?
- GCC options for strictest C code?
- How to do an explicit fall-through in C
- How do compilers treat CONST qualifier when the pointer points to a memory location obtained with malloc()?
- C: cmocka headers - how to unittest?
- Why in C when I print a double with a one decimal it round it to the next number
- Android C to Java SWIG unable to compile: incompatible types: byte cannot be converted to SWIGTYPE_p_uint8_t
- GNU Make in Ubuntu giving fatal error: rpc/types.h: No such file or directory
- How can I exclude non-numeric keys? CS50 Caesar Pset2
- How change every struct in an array of pointers?
- Optimized 2x2 matrix multiplication: Slow assembly versus fast SIMD
- Simple frame by frame video decoder library
- GCC no longer implements <varargs.h>
- Contents of IO buffer unknown == unsafe?