Search code examples
c++stringstrcmp

Can strcmp() work with strings in c++?

I have this line of code

if(strcmp(ob[i].getBrand(), ob[j].getBrand()) > 0)

and I get this error

error C2664: 'strcmp' : cannot convert parameter 1 from 'std::string' to 'const char *'

Does that mean that strcmp doesnt work with strings, but instead it has to convert it to char?

Solution

  • Don't use strcmp. Use std::string::compare which has the same behavior as strcmp.

    if(ob[i].getBrand().compare(ob[j].getBrand()) > 0)

    Or much better

    if(ob[i].getBrand() > ob[j].getBrand())

    Generally you should use std::string::compare when you have to test various cases where the strings will be different, e.g.

    auto cmp = ob[i].getBrand().compare(ob[j].getBrand());

if(cmp == 0) ...
else if(cmp > 0) ...
else if(cmp < 0) ...

    In this way you only have to do the comparison operation on the strings once.

    However, in your case where it's somehow apparent that you only have to use the comparison result in a single case (I'm really assuming, as I don't know the context of the code given), then operator > will suffice, and is much easier on the eye (the brain!).