Search code examples
javascriptjqueryeachcustom-data-attribute

Using jQuery to get data attribute values with .each()


I have the following HTML with data attributes - I want to write some jQuery that will loop through the HTML and collect the data attributes and put them into an array - could anyone assist as I'm getting an error.

I am trying to use the data() attribute - can you see what I'm doing wrong?

<span class="winners" data-userid="123" data-position="1" data-fullname="neil">
<span class="winners" data-userid="234" data-position="2" data-fullname="Ron">
<span class="winners" data-userid="421" data-position="3" data-fullname="Philip">
var multi = $('.winners');
var winners_array = [];

$.each(multi, function (index, item) {
    winners_array.push( {name: 'fullname', value: item.data('fullname')} );  
});

console.log(winners_array);

Console error:

item.data is not a function


Solution

  • item is not a jQuery object, the arguments for each are the index and the native DOM element

    var multi = $('.winners');
    var winners_array = [];
    
    $.each(multi, function (index, item) {
        winners_array.push( {name: 'fullname', value: $(item).data('fullname')} );  
    });
    

    using a map would be easier

    var winners_array = $.map($('.winners'), function(el) {
         return {name: 'fullname', value: $(el).data('fullname')}
    });