I have various custom context menus, based on ToolStripControlHost. They are wrapped inside ContextMenuStrip and placed in headers of DataGridView collumns (depending on some conditions) like this:
if (this.DGV.Columns[DGVColname] != null)
{
ContextMenuStrip cstr = null;
// there is always only one item in context menu
// I tried disposing in different manners, this is an example of my efforts
if (this.DGV.Columns[DGVColname].HeaderCell.ContextMenuStrip != null)
{
cstr = this.DGV.Columns[DGVColname].HeaderCell.ContextMenuStrip;
if (cstr.Items[0] != null)
{
cstr.Items[0].Dispose();
cstr.Items.Clear();
}
}
else
{
cstr = new ContextMenuStrip();
cstr.Opened += new EventHandler(cstr_Opened);
}
TextBoxToolStrip tsHost = new TextBoxToolStrip();
tsHost.Size = new System.Drawing.Size(172, 20);
tsHost.TextChanged += new EventHandler(myToolStrip_TextChanged);
cstr.ShowCheckMargin = false;
cstr.ShowImageMargin = false;
cstr.Margin = new Padding(0);
cstr.Padding = new Padding(0);
cstr.Items.Add(tsHost);
cstr.MaximumSize = new Size(tsHost.Width + 10, tsHost.Height + 10);
cstr.Size = cstr.MaximumSize;
cstr.LayoutStyle = ToolStripLayoutStyle.Flow;
DGV.Columns[DGVColname].HeaderCell.ContextMenuStrip = cstr;
}
Despite calling dispose and/or setting whatever I can get my hands on to nulls GDI object count for my app's proccess still increases in a steady manner. I have 20 collumns with menus in my DataGridView, and I get +30 or +34 (exactly) every time the code is called.
TextBoxToolStrip in this example extends ToolStripControlHost and contains a single TextBox:
public class TextBoxToolStrip : ToolStripControlHost
{
// .... some string or bool Properties here ....
public TextBox TextBoxControl
{
get { return Control as TextBox; }
}
public TextBoxToolStrip()
: base(new TextBox())
{
this.TextBoxControl.Anchor = ((System.Windows.Forms.AnchorStyles)(((System.Windows.Forms.AnchorStyles.Top | System.Windows.Forms.AnchorStyles.Left)
| System.Windows.Forms.AnchorStyles.Right)));
this.TextBoxControl.BorderStyle = System.Windows.Forms.BorderStyle.Fixed3D;
this.TextBoxControl.Location = new System.Drawing.Point(0, 3);
this.TextBoxControl.ReadOnly = false;
this.TextBoxControl.Font =
new System.Drawing.Font("Microsoft Sans Serif", 8.25F, System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(238)));
this.TextBoxControl.Size = new System.Drawing.Size(172, 20);
this.Size = new System.Drawing.Size(172, 20);
this.TextBoxControl.TabIndex = 0;
this.TextBoxControl.TextAlign = System.Windows.Forms.HorizontalAlignment.Left;
this.MouseHover += new EventHandler(TextBoxToolStrip_Enter);
this.AutoSize = false;
this.TextBoxControl.PreviewKeyDown += new PreviewKeyDownEventHandler(TextBoxPreviewKeyDown);
this.TextBoxControl.KeyDown += new KeyEventHandler(TextBoxControl_KeyDown);
}
protected override void OnSubscribeControlEvents(Control control)
{
base.OnSubscribeControlEvents(control);
TextBox tb = control as TextBox;
if (tb != null)
{
tb.TextChanged += new EventHandler(OnTextChanged);
}
}
protected override void OnUnsubscribeControlEvents(Control control)
{
base.OnUnsubscribeControlEvents(control);
TextBox tb = control as TextBox;
if (tb != null)
{
tb.TextChanged -= OnTextChanged;
}
}
private void TextBoxToolStrip_Enter(object sender, EventArgs e)
{
this.Focus();
}
private void TextBoxPreviewKeyDown(object sender, PreviewKeyDownEventArgs e)
{
if (e.KeyCode == Keys.Menu)
e.IsInputKey = true;
}
private void TextBoxControl_KeyDown(object sender, KeyEventArgs e)
{
TextBox txb = sender as TextBox;
ToolStripDropDown tsd = (ToolStripDropDown)txb.Parent;
if (e.KeyCode == Keys.Enter)
{
tsd.Close();
}
}
/// <summary>
/// Expose TextChanged event
/// </summary>
public new event EventHandler TextChanged;
private void OnTextChanged(object sender, EventArgs e)
{
if (TextChanged != null)
{
TextChanged(this, e);
}
}
QUESTION:
How can I properly dispose of the context menu?
It turned out it weren't events, static references or any of the usual stuff. I have ToolStripControlHosts bsed on TreeView, and it turned out only those were leaking. It appears that TreeView happily leaks resourcess on its own: when CheckBoxes property is set to true, the handles to bitmaps used to draw checked and unchecked checkboxes aren't properly released on dispose of TreeView (there was 4 of them left every time in my case), and that causes a GDI objects memory leak. I had to dispose of the checkbox imagelist manually.
The problem and the solution are described here. Although I used a property instead of an event here:
public new bool CheckBoxes
{
get
{
return base.CheckBoxes;
}
set
{
if (base.CheckBoxes == false)
{
base.CheckBoxes = true;
IntPtr handle = SendMessage(this.Handle, TVM_GETIMAGELIST, new
IntPtr(TVSIL_STATE), IntPtr.Zero);
if (handle != IntPtr.Zero)
_checkboxImageList = handle;
}
}
}
The StyleChanged event doesn't work in my case.