Search code examples
c#.netexceptiontry-catch

Exception on BitmapFrame.Create (bug in WPF framework?)


I implemented a C# application that recevies frame RGB at framerate of 30fps.

The event of frame arrive is managed with this code:

void client_ColorFrameReady(object sender, ColorFrameReadyEventArgs e)
{
    mycounter++;
    Console.WriteLine("new frame received: " + mycounter);

    if (writer != null)
    {
        count++;
        if (count % 2== 0)
        {
            using (var frame = BitmapImage2Bitmap(e.ColorFrame.BitmapImage))
            using (var thumb = ResizeBitmap(frame, 320, 240))
            {
                writer.WriteVideoFrame(thumb);
            }
        }
    }
    else
    {
        writer.Close();
    }
}

with the if condition I manage only one of two frames.

When my code call BitmapImage2Bitmap I obtain this exception:

enter image description here

The exception in english should be:

A first chance exception of type 'System.NotSupportedException' occurred in `PresentationCore.dll`
Additional information: BitmapMetadata is not available on BitmapImage.

The strange thing is that my application works "well" because the frames are correctly inserted in the output file.

I've read this, so the problem seems a bug in WPF framework.


Solution

  • This is by design. A first-chance exception notification doesn't mean that there's a problem. The relevant code inside the Create() method looks like this:

    try
    {
        metadata = source.Metadata as BitmapMetadata;
    }
    catch (NotSupportedException)
    {
    }
    

    In other words, the exception is expected and simply swallowed. Which is certainly very annoying since these exceptions do make the debugger stop when you have the Thrown checkbox checked in the Debug + Exception dialog. But it certainly is not a bug, this was intentionally written this way. Sometimes it is a lot cheaper to just let an exception be thrown and swallowing it instead of writing the code that prevents the exception. Especially when it gets unpractical to avoid the exception, the case with bitmaps since there are so many different kind of bitmap types. Some of which don't support metadata. Wherever this is done inside the framework code, it is almost always done to make the code faster. Speed is also an important aspect of code.

    Feature, not a bug. Untick the Thrown checkbox to avoid seeing these exceptions.