Search code examples
c#propertiesprivatesettergetter

c# getters setters style

I'm working on some code where there is lots of code like this:

private int x;

public void SetX(int new_x)
{
   this.SetXValue(new_x); 
}

private void SetXValue(int new_x)
{
   this.x = new_x; 
}

and similarly with properties:

private int x;

public int X 
{
    get { return this.GetX(); }
}

private int GetX()
{
    return this.x; 
}

What i don't get is why the need for the private methods which do the actual work, i.e. why not just have methods like this instead:

public void SetX(int new_x) 
{
  this.x = new_x;
}

public int X
{
    get { return this.x; }
}

is it just the other persons personal choice or is there some good reason for using the first way?

(i typed above code manually so sorry if any mistakes but you should hopefully see what i'm trying to say)

Cheers A

Solution

  • There's no reason for code like that as far as I can see. If you're not doing anything with the new values (like processing/checking before storing) and you're writing C# 3.0 you can actually just shorthand it it to this:

    public int MyProperty { get; set; }

    The compiler creates the backing store for you and you can just reference:

    this.MyProperty

    ...inside your class. You can also create get-only properties like:

    public int MyProperty { get; private set; }

    All of which I think is pretty neat!