Search code examples
open-sourcegithubpull-request

Etiquette of GitHub Contributing, Pull Requests vs New Issue


I was wondering what the proper etiquette to contributing on GitHub is?

Should you submit a "New Issue" first and discuss the problem?

Or do you take some initiative, code, then do a "Pull Request" and discuss the code further there?

My concern with creating a "New Issue" first is that if you do a "Pull Request" after, there would be two issues #'s created... seems like a waste.

Thanks!


Solution

  • The difference is quite clear:

    If you make a pull issue first, and then create a pull request, nothing stops you to reference the issue URL in your pull request comment, in order to avoid writing again the context of your patch.