textField:shouldChangeCharactersInRange:replacementString:

Question

How can I correct this code. I want only numbers and range should be not exceed to 10. My code is

- (BOOL)textField:(UITextField *)textField shouldChangeCharactersInRange:(NSRange)range replacementString:(NSString *)string {
    NSUInteger newLength = [textField.text length] + [string length] - range.length;
    return (newLength > 10) ? NO : YES;

    static NSCharacterSet *charSet = nil;
    if(!charSet) {
        charSet = [[[NSCharacterSet characterSetWithCharactersInString:@"0123456789"] invertedSet] retain];
    }
    NSRange location = [string rangeOfCharacterFromSet:charSet];
    return (location.location == NSNotFound);
}

Answer 1

The problem here is that anything after the first return is not executed.

- (BOOL)textField:(UITextField *)textField shouldChangeCharactersInRange:(NSRange)range replacementString:(NSString *)string {
    NSUInteger newLength = [textField.text length] + [string length] - range.length;
    return (newLength > 10) ? NO : YES;
    // unreachable!

So you are just checking the length but not whether the input is numerical. Change this line:

return (newLength > 10) ? NO : YES;

with this one:

if (newLength > 10) return NO;

and it should work. You can also optionally change this:

[NSCharacterSet characterSetWithCharactersInString:@"0123456789"]

with this:

[NSCharacterSet decimalDigitCharacterSet]