How do I remove multiple elements from an array?

Question

I want to write a function that passes an array and an optional number of values to be removed from the array as parameters. My function works when there is only 1 value, but fails when there is multiple values.

const removeFromArray = function (arr, ...theArgs) {
  for (let i = 0; i < arr.length; i++) {
    if (theArgs.includes(arr[i])) {
      arr.splice(i, 1);
    }
  }
  return arr;
};

Answer 1

The issue is with your indexing, you are finding the element using the index of arr, and deleting in the array, which is probably causing issue with indexing in loop. Modify your code as follows

const removeFromArray = function (arr, ...theArgs) {
  for (let i = 0; i < theArgs.length; i++) {
    if (arr.includes(theArgs[i])) {
      arr.splice(arr.indexOf(theArgs[i]), 1);
    }
  }
  return arr;
};

The above fixes the code your way, but a better way of doing it would be using filter.

const removeFromArray = function (arr, ...theArgs) {
  return arr.filter(ele => !theArgs.includes(ele))
}

I am writing it this way to purely maintain your function.