Search code examples
javascriptknex.jsbcrypt

My bcrypt.js hash returns undefined while all other inputs are fine


This code below returns the input password as undefined, but all other inputs are fine. I don't know what to do, if anyone can help please do.

I am using bcrypt.js with knex for psql.

app.post("/register", (req, res) => {
  const { email, name, password } = req.body;
   let salt = bcrypt.genSaltSync(10);
   let hash = bcrypt.hashSync(password, salt);
  
   knex
     .transaction((trx) => {
       trx
         .insert({
           hash: bcrypt.hashSync(password, salt),
           email: email,
         })
         .into("login")
         .returning("email")
         .then((loginEmail) => {
           return trx("users")
             .returning("*")
             .insert({
               email: loginEmail[0].email,
               name: name,
               joined: new Date(),
             })
             .then((user) => {
               res.json(user[0]);
             });
         })
         .then(trx.commit)
         .catch(trx.rollback);
     })
     .catch((err) => res.status(400).json("E-mail is already in use"));
});

*P.S. Using postman gives no errors. The error that comes in on the back-end terminal is Error: Illegal arguments: undefined, string meaning hash is undefined


Solution

  • I fixed it, was apparently a variable naming issue :) such a goof.

    password was actually being received as "hash" from the front-end, changed it to hash & changed hash to hashedPassword.

      const { email, name, hash } = req.body;
      let salt = bcrypt.genSaltSync(10);
      let hashedPassword = bcrypt.hashSync(hash, salt);
      
      knex
        .transaction((trx) => {
          trx
            .insert({
              hash: hashedPassword,
              email: email,
            })