Search code examples
postgresqlvariable-assignmentplpgsqlrowtype

Invalid input syntax for type integer: "(2,2)" with composite data type while executing function


begin;
create type public.ltree as (a int, b int);
create  table public.parent_tree(parent_id int,l_tree ltree);
insert into public.parent_tree values(1,(2,2)),(2,(1,2)),(3, (1,28));
commit;

Trying to replicate the solution in this answer:

For a function with composite type:

CREATE OR REPLACE FUNCTION public.get_parent_ltree
            (_parent_id int, tbl_name regclass , OUT _l_tree ltree)
  LANGUAGE plpgsql AS
$func$
BEGIN
   EXECUTE format('SELECT l_tree FROM %s WHERE parent_id = $1', tbl_name)
   INTO  _l_tree
   USING _parent_id;
END
$func$;

The effective query executed:

select l_tree from parent_tree where parent_id = 1;

Executing the function:

select get_parent_ltree(1,'parent_tree');
select get_parent_ltree(1,'public.parent_tree');

I get this error:

ERROR:  invalid input syntax for type integer: "(2,2)"  
CONTEXT:  PL/pgSQL function get_parent_ltree(integer,regclass) line 3 at EXECUTE

Context of line 3:

line3 pic


Solution

  • The output parameter _l_tree is a "row variable". (A composite type is treated as row variable.) SELECT INTO assigns fields of a row variable one-by-one. The manual:

    The optional target is a record variable, a row variable, or a comma-separated list of simple variables and record/row fields, [...]

    So, currently (pg 14), a row or record variables must stand alone as target. Or as the according Postgres error message would put it:

    ERROR:  record variable cannot be part of multiple-item INTO list
    

    This works:

    CREATE OR REPLACE FUNCTION public.get_parent_ltree (IN  _parent_id int
                                                      , IN  _tbl_name  regclass
                                                      , OUT _l_tree    ltree)
      LANGUAGE plpgsql AS
    $func$
    BEGIN
       EXECUTE format('SELECT (l_tree).* FROM %s WHERE parent_id = $1', _tbl_name)
       INTO  _l_tree
       USING _parent_id;
    END
    $func$;
    

    Or this:

    CREATE OR REPLACE FUNCTION public.get_parent_ltree2 (IN  _parent_id int
                                                       , IN  _tbl_name  regclass
                                                       , OUT _l_tree    ltree)
      LANGUAGE plpgsql AS
    $func$
    BEGIN
       EXECUTE format('SELECT (l_tree).a, (l_tree).b FROM %s WHERE parent_id = $1', _tbl_name)
       INTO  _l_tree.a, _l_tree.b
       USING _parent_id;
    END
    $func$;
    

    db<>fiddle here

    I agree that this is rather tricky. One might expect that a composite field is treated as a single field (like a simple type). But that's currently not so in PL/pgSQL assignments.

    A related quote from the manual about composite types:

    A composite type represents the structure of a row or record; it is essentially just a list of field names and their data types. PostgreSQL allows composite types to be used in many of the same ways that simple types can be used.

    Bold emphasis mine.
    Many. Not all.

    Related:


    Aside: Consider the additional module ltree instead of "growing your own". And if you continue working with your own composite type, consider a different name to avoid confusion / conflict with that module.