SwiftUI: How to update image to filled / outlined in TabView

Question

I'm trying to use filled image when it is selected and outlined image when it is deselected. I tried to render the images but still filled

So I thought this would work, but it doesn't:

struct ListTabView: View {

    @State private var selectedTab = 0

    var body: some View {

        NavigationView {

            TabView(selection: $selectedTab) {

                Text("Tab 1")
                    .onTapGesture {
                        self.selectedTab += 1
                    }
                    .tabItem {
                        selectedTab == 0 ? Image(systemName: "star.fill") : Image(systemName: "star")
                        Text("First")
                    }
                    .tag(0)

                Text("Tab 2")
                    .onTapGesture {
                        self.selectedTab -= 1
                    }
                    .tabItem {
                        selectedTab == 1 ? Image(systemName: "moon.stars.fill") : Image(systemName: "moon.stars")
                        Text("Second")
                    }
                    .tag(1)
            }
            .accentColor(.pink)
            .onAppear {
                UITabBar.appearance().barTintColor = .white
            }
        }
    }
}

struct ListTabView_Previews: PreviewProvider {
    static var previews: some View {
        ListTabView()
    }
}

Answer 1

Your code actually works. The issue is something else not documented that I can find. If you use a non .fill variant of an SF Font, the .fill variant will be substituted. Use the following code to test it:

TabView(selection: $selectedTab) {
    VStack {
        Text("Tab 1")
        Text(Image(systemName: "star"))
    }
    .tabItem {
        selectedTab == 0 ? Image(systemName: "star") : Image(systemName: "sun.max")
        Text("First")
    }
    .tag(0)
    
    VStack {
        Text("Tab 2")
        Text(Image(systemName: "moon.stars"))
    }
    .tabItem {
        selectedTab == 1 ? Image(systemName: "moon.stars") : Image(systemName: "sun.max")
        Text("Second")
    }
    .tag(1)
}

You will note I used plain variants, and yet the filled variant was used. Also, you don't need the .onTap(), but I suspect you added it when the images didn't seem to switch.