Search code examples
androidxmldialogandroid-stylesandroid-dialog

How do I add back the transparent background around my dialog activity with a custom theme


I have an activity and I've set it's theme in the manifest to a custom dialog theme.
But now the transparency around the dialog box is gone. Everything is black.

Here's what it looks like with my custom theme:

I want it to look like this:

But with a custom background and text color, like in the first picture.

Here's the part of the manifest with the activity's theme set to my custom theme, as in the first picture:

    <activity
        android:name=".activity.LockScreenActivity"
        android:exported="true"
        android:label="@string/aplicacao_bloqueada_title"
        android:theme="@style/dialog_theme"/>

Here's the part of the manifest with the activity's theme set to android's dialog theme, as in the second picture:

    <activity
        android:name=".activity.LockScreenActivity"
        android:exported="true"
        android:label="@string/aplicacao_bloqueada_title"
        android:theme="@style/Theme.AppCompat.DayNight.Dialog"/>

Here's my xml with my custom theme:

<style name="dialog_theme" parent="Theme.AppCompat.DayNight.Dialog">

        <item name="android:textColor">@color/white</item>
        <item name="android:windowBackground">@color/dark_gray</item>
        <item name="android:backgroundDimEnabled">true</item>
        <item name="android:backgroundDimAmount">50</item>

</style>

Here's my activity class:

public class LockScreenActivity extends AppCompatActivity {

    // Notification activity that is called after too many failed login attempts

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_lock_screen);
        Handler handler = new Handler();
        handler.postDelayed(new Runnable() {
            @Override
            public void run() {
                finishAndRemoveTask();
                System.exit(0);
            }
        }, 5000);
    }
}

Layout for my activity:

<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    tools:context=".activity.LockScreenActivity">

    <TextView
        android:id="@+id/textView2"
        android:layout_width="214dp"
        android:layout_height="136dp"
        android:gravity="center_vertical"
        android:padding="20dp"
        android:text="@string/aplicacao_bloqueada_text"
        android:textAlignment="viewStart"
        android:textSize="16sp"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHorizontal_bias="0.497"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>

What's the best way to do this?

Edit: As nima sugested, I tried adding the following line to the onCreat method of my dialog themed class:

getWindow().setBackgroundDrawable(new ColorDrawable(Color.TRANSPARENT));

But it turned everything transparent, including the pop up window. See picture:

enter image description here

How do I solve this?


Solution

  • As @nima pointed out you can use getWindow().setBackgroundDrawable(new ColorDrawable(Color.TRANSPARENT)); to make the background transparent.

    This will introduce a couple of issues:

    • Transparency of everything

      Fix this by setting a white background to the ConstraintLayout root layout.

    • Transparent activity title

      Fix this by removing the title from the manifest and set it to an empty one in activity with setTitle(""); and add another TextView to represent the title in the layout:

    Remove the title (android:label) from the activity in the manifest: Also you should android:exported="true" as it seems that this activity should be exported to other apps:

    <activity
        android:name=".activity.LockScreenActivity"
        android:theme="@style/Theme.AppCompat.DayNight.Dialog"/>
    

    Set the title & background:

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_lock_screen);
       
        // ...........
    
        getWindow().setBackgroundDrawable(new ColorDrawable(Color.TRANSPARENT));
        setTitle("");
    
    }
    

    Layout:

    <?xml version="1.0" encoding="utf-8"?>
    <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:app="http://schemas.android.com/apk/res-auto"
        xmlns:tools="http://schemas.android.com/tools"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:background="@color/white"
        android:paddingHorizontal="16dp"
        android:paddingTop="16dp"
        tools:context=".LockScreenActivity">
    
        <TextView
            android:id="@+id/textView1"
            android:layout_width="0dp"
            android:layout_height="wrap_content"
            android:text="Application Blocked"
            android:textSize="22sp"
            android:textStyle="bold"
            app:layout_constraintStart_toStartOf="@id/textView2"
            app:layout_constraintTop_toTopOf="parent" />
    
        <TextView
            android:id="@+id/textView2"
            android:layout_width="214dp"
            android:layout_height="136dp"
            android:gravity="center_vertical"
            android:padding="20dp"
            android:text="@string/aplicacao_bloqueada_text"
            android:textAlignment="viewStart"
            android:textSize="16sp"
            app:layout_constraintBottom_toBottomOf="parent"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintHorizontal_bias="0.497"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toBottomOf="@+id/textView1" />
    </androidx.constraintlayout.widget.ConstraintLayout>
    

    UPDATE:

    When I use my custom theme, as opposed to Theme.AppCompat.DayNight.Dialog, I still get the black screen

    This is because the android:backgroundDimAmount is set to 50 in your custom theme; the valid range for this attribute is 0 through 1; any value greater than that will be considered 1...

    0 means there is no dimming (completely transparent, and 1 meaning 100% opaque/black.

    So to fix this issue, I guess you mean by 50 as the half way, so you'd set it to 0.5 instead:

    <style name="dialog_theme" parent="Theme.AppCompat.DayNight.Dialog">
            <item name="android:textColor">@color/white</item>
            <item name="android:windowBackground">@color/dark_gray</item>
            <item name="android:backgroundDimEnabled">true</item>
            <item name="android:backgroundDimAmount">0.5</item>
    </style>