Search code examples
androidandroid-recyclerviewonclicklistener

Null Listener in RecyclerView Adapter


Listener in Android Studio RecyclerView custom adapter is returning null.

This is the Interface

  private OnItemClickListener mlistener;

    public interface OnItemClickListener{
        void onItemClick(int position, Boolean paid);
    }
    public void setOnItemClickListener(OnItemClickListener listener){
        mlistener = listener;
    }

And this is the View Holder with the Listener. This is intended to pass a Boolean to the main activity.

 public CartViewHolder(View itemView, ArrayList<Shift> shifts, OnItemClickListener listener) {
            super(itemView);

         
            paid = itemView.findViewById(R.id.due_back_paid);
            containerView = itemView.findViewById(R.id.container);


            paid.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
                @Override
                public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {

                    if (listener !=  null){
                        int position = getAdapterPosition();
                        if(position != RecyclerView.NO_POSITION){
                            listener.onItemClick(position, isChecked);
                        }
                    }
                }
            });


            containerView.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    Shift current = (Shift)containerView.getTag();
                    Intent intent = new Intent(v.getContext(), ViewShiftActivity.class);
                    intent.putExtra("thisShift", current);
                    intent.putExtra("shifts", shifts);
                    v.getContext().startActivity(intent);

                }
            });


        }


    }

    public LoadAdapter(ArrayList<Shift> shifts){
        shiftList = shifts;
    }

    @NonNull
    @Override
    public CartViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
        View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.shift_row, parent, false);
        CartViewHolder mvh = new CartViewHolder(view, shiftList, mlistener);
        return mvh;
    }

I have used this code in other projects and it works. I have can't seem to figure out what I am missing.

I've been asked to include the activity. The following is this code. I have not added any code to the onItemClick here yet. waiting for the listener to work.

public class EditShiftActivity extends AppCompatActivity implements LoadAdapter.OnItemClickListener{

    private ArrayList<Shift> shifts;
    private RecyclerView lRecyclerView;
    private LoadAdapter lAdapter;
    private RecyclerView.LayoutManager lLayoutManager;
    private View view;
    private FloatingActionButton fab;
    
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_edit_shift);

        Intent intent = getIntent();
        shifts = intent.getParcelableArrayListExtra("shifts");

        fab = findViewById(R.id.add_shift_edit);
        fab.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent intent1 = new Intent(EditShiftActivity.this, AddShiftActivity.class);
                intent1.putExtra("shifts", shifts);
                intent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
                v.getContext().startActivity(intent1);
            }
        });
        
        lRecyclerView = findViewById(R.id.shift_recycler);
        lLayoutManager = new LinearLayoutManager(this);
        lAdapter = new LoadAdapter(shifts);
        lRecyclerView.setLayoutManager(lLayoutManager);
        lRecyclerView.setAdapter(lAdapter);
    }
    
    @Override
    public void onItemClick(int position, Boolean paid) {

    }
}

Solution

  • Add below line in your code -

    lAdapter = new LoadAdapter(shifts);
    lAdapter.setOnItemClickListener(this);