Search code examples
swiftgenericsmappingprotocolsdecodable

Cannot map protocol compliant elements to generic elements


As you can see below, I downloaded an array of structures containing heterogeneous objects that were decoded into enums containing nested objects.

I would now like to put said objects into a generic Model structure, but the compiler won't allow this - the error is described below in the code comment. I am relatively new to programming in Swift, I would appreciate your help.

import Foundation

let jsonString = """
{
  "data":[
    {
      "type":"league",
      "info":{
        "name":"NBA",
        "sport":"Basketball",
        "website":"https://nba.com/"
      }
    },
    {
      "type":"player",
      "info":{
        "name":"Kawhi Leonard",
        "position":"Small Forward",
        "picture":"https://i.ibb.co/b5sGk6L/40a233a203be2a30e6d50501a73d3a0a8ccc131fv2-128.jpg"
      }
    },
    {
      "type":"team",
      "info":{
        "name":"Los Angeles Clippers",
        "state":"California",
        "logo":"https://logos-download.com/wp-content/uploads/2016/04/LA_Clippers_logo_logotype_emblem.png"
      }
    }
  ]
}
"""

struct Response: Decodable {
    let data: [Datum]
}

struct League: Codable {
    let name: String
    let sport: String
    let website: URL
}

extension League: Displayable {
    var text: String { name }
    var image: URL { website }
}

struct Player: Codable {
    let name: String
    let position: String
    let picture: URL
}

extension Player: Displayable {
    var text: String { name }
    var image: URL { picture }
}

struct Team: Codable {
    let name: String
    let state: String
    let logo: URL
}

extension Team: Displayable {
    var text: String { name }
    var image: URL { logo }
}

enum Datum: Decodable {
    case league(League)
    case player(Player)
    case team(Team)
    
    enum DatumType: String, Decodable {
        case league
        case player
        case team
    }
    
    private enum CodingKeys : String, CodingKey { case type, info }
 
    init(from decoder : Decoder) throws {
        let container = try decoder.container(keyedBy: CodingKeys.self)
        let type = try container.decode(DatumType.self, forKey: .type)
        switch type {
        case .league:
            let item = try container.decode(League.self, forKey: .info)
            self = .league(item)
        case .player:
            let item = try container.decode(Player.self, forKey: .info)
            self = .player(item)
        case .team:
            let item = try container.decode(Team.self, forKey: .info)
            self = .team(item)
        }
    }
}

protocol Displayable {
    var text: String { get }
    var image: URL { get }
}
 
struct Model<T: Displayable> {
    let text: String
    let image: URL
    
    init(item: T) {
        self.text = item.text
        self.image = item.image
    }
}

do {
    let response = try JSONDecoder().decode(Response.self, from: Data(jsonString.utf8))
    let items = response.data
    let models = items.map { (item) -> Model<Displayable> in // error: only struct/enum/class types can conform to protocols
        switch item {
        case .league(let league):
            return Model(item: league)
        case .player(let player):
            return Model(item: player)
        case .team(let team):
            return Model(item: team)
        }
    }
} catch {
    print(error)
}

Solution

  • You do not need generics here.

    Change Model to accept any type that conforms to Displayable in the init

    struct Model {
        let text: String
        let image: URL
    
        init(item: Displayable) {
            self.text = item.text
            self.image = item.image
        }
    }
    

    and then change the closure to return Model

    let models = items.map { (item) -> Model in
    

    If you want to keep your Model struct generic then you need to change the map call to

    let models: [Any] = items.map { item -> Any in
        switch item {
        case .league(let league):
            return Model(item: league)
        case .player(let player):
            return Model(item: player)
        case .team(let team):
            return Model(item: team)
        }
    }
    

    This will give the following output when conforming to CustomStringConvertible

    extension Model: CustomStringConvertible {
        var description: String {
            "\(text) type:\(type(of: self))"
        }
    }
    
    print(models)
    

    [NBA type:Model<League>, Kawhi Leonard type:Model<Player>, Los Angeles Clippers type:Model<Team>]