Search code examples
swiftcore-dataxcode12

How can I fix error that can't fetch image from Core Data?


I want to fetch image that picked from photo library and saved already, but have trouble in fetching image data. When I debugged, log said "Saved Image" but in DetailViewController, "No Image fetch". Do you have any ideas that I miss something ? Thanks

Core Data

enter image description here

Data Manager : a part of methods related to save and fetch memo.

class DataManager {
    static let shared = DataManager()
    
    private init() {
        
    }
    
    var mainContext: NSManagedObjectContext {
        return persistentContainer.viewContext
    }
    
    var memoList = [Memo]()

    func fetchMemo() {
        let request: NSFetchRequest<Memo> = Memo.fetchRequest()
        
        let sortByDateDesc = NSSortDescriptor(key: "insertDate", ascending: false)
        request.sortDescriptors = [sortByDateDesc]
        
        do {
            memoList = try mainContext.fetch(request)
        } catch {
            print(error)
        }
    }
    
    func addNewMemo(_ memo: String?) {
        
        let newMemo = Memo(context: mainContext)
        newMemo.content = memo
        newMemo.insertDate = Date()

        memoList.insert(newMemo, at: 0)
        
        saveContext()
    }
    

    func deleteMemo(_ memo: Memo?) {
        if let memo = memo {
            mainContext.delete(memo)
            saveContext()
        }
    }

    func saveImage(data: Data) {
        let memo = Memo(context: mainContext)
        memo.image = data
        saveContext()

    }

ComposeViewController : where I save image picked from photo library

if let memoImage = imageView.image?.pngData() {
                DataManager.shared.saveImage(data: memoImage)
                DataManager.shared.saveContext()

                print("Saved Image") 
            }

            DataManager.shared.addNewMemo(memo)
            NotificationCenter.default.post(name: ComposeViewController.newMemoDidInsert, object: nil)
        }

DetailViewController : where I want to fetch image

DispatchQueue.main.async {
            if let memoImage = self.memo.image {
                self.imageView.image = UIImage(data: memoImage as Data)
            } else {
                print("No image fetch")
            }
        }

enter image description here

enter image description here


Solution

  • You are saving 2 Memo objects, one without the image and one with only the image. I would delete the saveImage function and add the image (Data) as a parameter to the addNewMemo function and then adjust the calling code.

    func addNewMemo(_ memo: String?, image: Data?) {        
        let newMemo = Memo(context: mainContext)
        newMemo.content = memo
        newMemo.insertDate = Date()
        if let data = image {
            newMemo.image = data
        }
    
        memoList.insert(newMemo, at: 0)
        
        saveContext()
    }
    

    Calling code

    let memoImage = imageView.image?.pngData()
    DataManager.shared.addNewMemo(memo, image: memoImage)
    
    NotificationCenter.default.post(name: ComposeViewController.newMemoDidInsert, object: nil)