Twofold Question; Calling a random integer in a range through a function in Python 3.9

Question

This is really a twofold question, since I know there are two errors with the same couple blocks of code.

I'm essentially making an interactive story that changes based on "rolling a d20." For instance, the player is presented with a scenario, and prompted to roll a d20. The computer generates a number between 1 and 20, and, depending on the roll, the story will pan out a certain way. The roadblock I'm having is that I've defined a function, "RollD20()," that stores the value of variable "n" as a random integer between 1 and 20 and then prints the value rolled. When I call the function, it crashes with an error saying "n is not defined."

The other part to this question, in the same block of code, is that I'm trying to get to a point where the game will ask the user essentially, do you want to play? and if the answer constitutes a yes, then the rest of it plays out. If not, the process ends. But thus far, regardless of what key I press, y or yes, n or no, or even enter, it doesn't end the process like it's supposed to, it just moves forward. Is there an easy way to fix this?

Thanks, and the code is below.

---

import sys
import random

while True:

    def NewGame():
        print(input("Hello! Would you like to go on an adventure? y/n >> "))
        if input == "y" or "yes":
            print("Great! Roll the dice.")
            print(input("Press R to roll the D20."))
            print("You rolled a " + RollD20(n) + "!")
        else:
            print(input("Okay, bye! Press any key to exit."))
            sys.exit()


    def RollD20():
        n = random.randint(1, 20)
        print(n)


    NewGame()

---

Traceback (most recent call last):
\venv\main.py", line 22, in <module>
    NewGame()
\venv\main.py", line 11, in NewGame
    print("You rolled a " + RollD20(n) + "!")
NameError: name 'n' is not defined

Process finished with exit code 1

Answer 1

Alright, there are a lot of mistakes with your code, so I'll go over each of them.

1. You need to assign the input to a variable, so you can compare it in the if-statement. You should never name variables after existing Python functions or objects, so I named it inp.

2. There's really no need to print every single input statement; just call input.

3. Instead of x == "y" or "yes", you need to do x == "y" or x == "yes".

4. For the RollD20 function, instead of printing n you should return it, as you use the returned value in the NewGame function.

5. In the NewGame function, you don't need to pass any parameters to RollD20. Also, since it returns an integer, you must convert the result to a string in order to print it.

With that said, below is the full corrected code:

import sys
import random

while True:

    def NewGame():
        inp = input("Hello! Would you like to go on an adventure? y/n >> ")
        if inp == "y" or inp == "yes":
            print("Great! Roll the dice.")
            input("Press R to roll the D20.")
            print("You rolled a " + str(RollD20()) + "!")
        else:
            input("Okay, bye! Press any key to exit.")
            sys.exit()


    def RollD20():
        n = random.randint(1, 20)
        return n 


    NewGame()