Search code examples
androidandroid-layoutandroid-fragmentsandroid-toolbarandroid-optionsmenu

Not clickable options menu item in fragment


I have a fragment with toolbar, I need to handle navigation by the click on options menu item. At first i thought the problem is navigation, but then I supposed that it just not clickable. I tried to use Toast to see if it's working and it's not. Layout screenshot

CocktailListFragment

class CocktailListFragment : Fragment() {

    private val viewModel: CocktailListViewModel by lazy {
        ViewModelProvider(this).get(CocktailListViewModel::class.java)
    }

    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
    ): View {
        val binding = CocktailListFragmentBinding.inflate(inflater)
       ...
        setHasOptionsMenu(true)

        return binding.root
    }

    override fun onCreateOptionsMenu(menu: Menu, inflater: MenuInflater) {
        inflater.inflate(R.menu.filter_menu, menu)
        super.onCreateOptionsMenu(menu, inflater)
    }

    override fun onOptionsItemSelected(item: MenuItem): Boolean {

        return when (item.itemId) {
            R.id.filter -> {
                Toast.makeText(context, "Filter clicked", Toast.LENGTH_LONG).show()
                true
            } else -> super.onOptionsItemSelected(item)
        }
    }
}

Can this problem be connected with layout?

filter_list.xml

<layout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools">

    <data>
        <variable
            name="cocktail"
            type="com.example.coctaildb.cocktaillist.CocktailListViewModel" />
    </data>

    <androidx.constraintlayout.widget.ConstraintLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent">

            <androidx.appcompat.widget.Toolbar
                android:id="@+id/toolbar"
                android:layout_width="match_parent"
                android:layout_height="?attr/actionBarSize"
                style="@style/Widget.AppCompat.Toolbar"
                android:background="@android:color/white"
                app:menu="@menu/filter_menu"
                app:title="@string/drinks"
                android:elevation="20dp"
                app:titleTextColor="@android:color/black"
                app:layout_constraintEnd_toEndOf="parent"
                app:layout_constraintStart_toStartOf="parent"
                app:layout_constraintTop_toTopOf="parent"/>


        <androidx.recyclerview.widget.RecyclerView
            ... />

    </androidx.constraintlayout.widget.ConstraintLayout>
</layout>

Here my menu file:

<menu xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:android="http://schemas.android.com/apk/res/android">
    <item
        android:id="@+id/filter"
        android:icon="@drawable/ic_filter_icon"
        android:title="@string/filters"
        app:showAsAction="always" />
</menu>

Solution

  • Try to handle your click events with the OnMenuItemClickListener method:

    class CocktailListFragment : Fragment() {
    
        private val viewModel: CocktailListViewModel by lazy {
            ViewModelProvider(this).get(CocktailListViewModel::class.java)
        }
    
        override fun onCreateView(
            inflater: LayoutInflater,
            container: ViewGroup?,
            savedInstanceState: Bundle?
        ): View {
            val binding = CocktailListFragmentBinding.inflate(inflater)
           ...
            binding.root.toolbar.setOnMenuItemClickListener { item ->  
                when (item.itemId) {
                    R.id.filter -> {
                        Toast.makeText(context, "Filter clicked", Toast.LENGTH_LONG).show()
                        true
                    }
                }
    
                false
            }
    
            return binding.root
        }
    }