Search code examples
c#jsonclasssettingsjsonserializer

Correctly create a json file in c#

I'm currently setting-up my application, and i need to manage a json file (that contain some settings) in my windows form. Once you open it, you can easy choose different settings, and once you've done, you can save it (which mean i need to overwrite the existing one json file settings, and replace it with new one!

I tried to follow this guide for correctly create my json file! But i met 2 problems:

  1. This solution mentioned up, create square brackets (which i don't need!)
  2. Seems to create all settings on one line. Is that correct or it could make some problem in the future?

Some materials....

My application:

Original json file:

Json file generated with my code:

My class:

    public class data
    {
        public bool avx { get; set; }
        public bool memory_pool { get; set; }
        public bool smt { get; set; }
        public bool spectre { get; set; }
        public bool unlock_menu { get; set; }
        public bool vinput { get; set; }
        public double cpu_memory_pool_fraction { get; set; }
        public double gpu_memory_pool_fraction { get; set; }
    }

My code:

private void btn_save_Click(object sender, EventArgs e)
{
    string settings_path = general_path + "\\plugins\\cyber_engine_tweaks\\" + "config.json"; //path

    bool avx_set = cb_avx.Checked;
    bool smt_set = cb_smt.Checked;
    bool memory_set = cb_memory.Checked;
    bool spectre_set = cb_spectre.Checked;
    bool debug_set = cb_debug.Checked;
    bool vinput_set = cb_vinput.Checked;

    List<data> _data = new List<data>();
    _data.Add(new data()
    {
        avx = avx_set,
        cpu_memory_pool_fraction = 0.5,
        gpu_memory_pool_fraction = 1.0,
        memory_pool = memory_set,
        smt = smt_set,
        spectre = spectre_set,
        unlock_menu = debug_set,
        vinput = vinput_set
    });

    using (StreamWriter file = File.CreateText(settings_path))
    {
        JsonSerializer serializer = new JsonSerializer();
        //serialize object directly into file stream
        serializer.Serialize(file, _data);
    }
}
Solution

    1. Square brackets are because you send an array:
      Instead of List<data> _data = new List<data>(); _data.Add(new data()...
      try var data = new data()... serializer.Serialize(file, data)

    2. All settings on one line is normal.