I am using CERN ROOT 6.22/00 (as required for a class). I am trying to read an "input file" with two columns of data like so:
40000 1397251483
40000 1397251484
40010 1397251485
40012 1397251486
40004 1397251487
40003 1397251488
40014 1397251489
Here is a minimally reproducible version of my code that produces the error:
# include <iostream> // Header that defines the standard input/output stream objects:
# include <fstream> // Input/output stream class to operate on files.
# include <math.h> // Header declares a set of functions to compute common mathematical operations and transformations.
# include <iomanip> // Header providing parametric manipulators.
using namespace std;
int main()
{
ifstream inFile;
cout << "TEST";
int NumOfRows = 1131635;
char inputFileName[30] = "input.dat"; //File with the model parameters
char outputFileName[30] = "output.dat";
const int nArray = NumOfRows + 1;
double paramOne[nArray];
double T[nArray];
//Reading input parameters from file into arrays//
inFile.open(inputFileName,ios::in);
return 0;
}
However, when ever I go ahead and run this code, ROOT quits out and I am back in the terminal. I have also tried to run the code using g++ but I get the error:
Segmentation fault (core dumped)
Any suggestions?
Edit: So I went ahead and converted the arrays into vectors like so:
// V2: converted arrays to vectors to avoid memory problems
# include <iostream> // Header that defines the standard input/output stream objects:
# include <fstream> // Input/output stream class to operate on files.
# include <math.h> // Header declares a set of functions to compute common mathematical operations and transformations.
# include <iomanip> // Header providing parametric manipulators.
using namespace std;
int main()
{
ifstream inFile;
int NumOfRows = 10;
char inputFileName[30] = "input.dat"; //File with the model parameters
char outputFileName[30] = "output.dat";
vector<int> TDC;
vector<int> T;
//Reading input parameters from file into arrays//
inFile.open(inputFileName,ios::in);
// Warning if file cant be opened
if(!inFile.is_open()){
cout << "Error opening file. \n";
//cout << "Giving Retry... \n";
}
if(inFile.is_open()){
cout<<"Input File was opened successfully"<<endl;
}
if(inFile.good()){
cout<<"Input File is ready for reading"<<endl;
}
cout<< fixed;
int rejects = 0;
//reading file
if(inFile.is_open()){
// Putting cursor at start of file
inFile.clear();
//Reading first line
inFile >> TDC[0] >> T[0];
cout<<"TDC time"<<setw(15)<<"timestamp"<<endl;
cout<<TDC[0]<<setw(20)<<T[0]<<endl;
}
return 0;
}
I am still facing memory issues at the moment:
Input File was opened successfully
Input File is ready for reading
*** Break *** segmentation violation
===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================
#0 0x00007fdc11e1d6e7 in waitpid () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x00007fdc11d88107 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#2 0x00007fdc129bfed3 in TUnixSystem::StackTrace() () from /home/nick/root/lib/libCore.so.6.22
#3 0x00007fdc129c29c5 in TUnixSystem::DispatchSignals(ESignals) () from /home/nick/root/lib/libCore.so.6.22
#4 <signal handler called>
#5 0x00007fdc1243d8c8 in std::istream::operator>>(int&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6 0x00007fdc1320eab8 in ?? ()
#7 0x0000558f085c6f00 in ?? ()
#8 0x0ab62774202a8500 in ?? ()
#9 0x0000000000000000 in ?? ()
===========================================================
The lines below might hint at the cause of the crash.
You may get help by asking at the ROOT forum http://root.cern.ch/forum
Only if you are really convinced it is a bug in ROOT then please submit a
report at http://root.cern.ch/bugs Please post the ENTIRE stack trace
from above as an attachment in addition to anything else
that might help us fixing this issue.
===========================================================
#5 0x00007fdc1243d8c8 in std::istream::operator>>(int&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6 0x00007fdc1320eab8 in ?? ()
#7 0x0000558f085c6f00 in ?? ()
#8 0x0ab62774202a8500 in ?? ()
#9 0x0000000000000000 in ?? ()
===========================================================
EDIT 2: Using the suggested solution:
// V2: converted arrays to vectors to avoid memory problems
# include <iostream> // Header that defines the standard input/output stream objects:
# include <fstream> // Input/output stream class to operate on files.
# include <math.h> // Header declares a set of functions to compute common mathematical operations and transformations.
# include <iomanip> // Header providing parametric manipulators.
using namespace std;
int main()
{
ifstream inFile;
int NumOfRows = 1131636;
char inputFileName[30] = "input.dat"; //File with the model parameters
char outputFileName[30] = "output.dat";
size_t reasonableTDCSize = 1131635;
vector<int> TDC(NumOfRows);
vector<int> T(NumOfRows);
//Reading input parameters from file into arrays//
inFile.open(inputFileName,ios::in);
// Warning if file cant be opened
if(!inFile.is_open()){
cout << "Error opening file. \n";
//cout << "Giving Retry... \n";
}
if(inFile.is_open()){
cout<<"Input File was opened successfully"<<endl;
}
if(inFile.good()){
cout<<"Input File is ready for reading"<<endl;
}
cout<< fixed;
int rejects = 0;
int tempTDC = 0;
int tempT = 0;
//reading file
if(inFile.is_open()){
// Putting cursor at start of file
inFile.clear();
//Reading first line
inFile >> tempTDC >> tempT;
TDC.push_back(tempTDC);
T.push_back(tempT);
cout<<"TDC time"<<setw(15)<<"timestamp"<<endl;
cout<<TDC[0]<<setw(20)<<T[0]<<endl;
for (int a = 1; a < NumOfRows; a++){
inFile >> tempTDC >> tempT;
if ( tempTDC >= 40000 )
{
++rejects;
break;
}
cout<<tempTDC<<setw(20)<<tempT<<endl;
// Reading rest of file
TDC.push_back(tempTDC);
T.push_back(tempT);
//cout<<Mod[a]<<setw(15)<<z[a]<<setw(15)<<x[a]<<setw(15)<<M[a]<<setw(15)<<L[a]<<setw(15)<<T[a]<<endl;
}
//To show last and first index only, have this line uncommmented and the cout line in loop commented
cout<<TDC[NumOfRows-1]<<setw(20)<<T[NumOfRows-1]<<endl;
// Close the file.
inFile.close();
}
/*
cout<< "Lines remaining " << NumOfRows - rejects << endl;
if(!inFile.is_open()){
cout<<"Input File closed successfully"<<endl;
}
cout<< "Timestamp difference between first and last line is: " << T[NumOfRows-1] - T[0] << endl;
cout<<"Creating output file"<<endl;
ofstream outFile(outputFileName);
outFile<<"TDC time"<<setw(15)<<"timestamp"<<endl; //Header
for (int a = 1; a < NumOfRows; a++){
// Reading rest of file
outFile << TDC[a] << T[a];
}
outFile<<""<<endl;
// Warning if file cant be opened
if(!outFile.is_open()){
cout << "Error opening file. \n";
//cout << "Giving Retry... \n";
}
if(outFile.is_open()){
cout<<"Output File was opened successfully"<<endl;
}
if(outFile.good()){
cout<<"Output File is ready for reading"<<endl;
}
outFile.close();
if(!outFile.is_open()){
cout<<"Output File closed successfully"<<endl;
}
*/
return 0;
}
In the improved version ("V2") you need to size the vector appropriately.
You can do this like:
size_t reasonableTDCSize = /* some value */;
size_t reasonableTSize = /* some value */;
vector<int> TDC(reasonableTDCSize);
vector<int> T(reasonableTSize);
I don't quite understand what you're trying to do, but you could, for example, do:
vector<int> TDC(NumOfRows);
vector<int> T(NumOfRows);
... if this makes sense semantically. Once you have them sized correctly, your code works.