Solving problem to generate custom number from inserted values with GUI in Python

Question

Hello im having python learning project. I want to insert in GUI two numbers, which are defining range for program to generate random number from.

I am really having problems with calling function with press of the button. And constantly getting error ValueError: invalid literal for int() with base 10: '', when trying to convert string from entry in GUI to int and then inserting them into random.randint.

Thx for Help!

from tkinter import *
import random

root = Tk()
root.title("Generator custom random number")

#function that gets number from entry converts string to int and defines target number in stevilo
def function():
    string_answer1 = prvo_stevilo.get()
    int1 = int(string_answer1)
    string_answer2 = drugo_stevilo.get()
    int2 = int(string_answer2)
    stevilo = random.randint(int1, int2)


#Defining GUI
navodilo = Label(root, text="Choose custom lower and upper number to chose random number from", width=60)
navodilo2 = Label(root, text="From", width=20, borderwidth=3)
navodilo3 = Label(root, text="To", width=20, borderwidth=3)
prvo_stevilo = Entry(root, width=20, borderwidth=3)
drugo_stevilo = Entry(root, width=20, borderwidth=3)
gumb = Button(root, text="Generate number", width=17, height=2, command=function)
praznavrstica = Label(root, text="")
izpis = Label(root, text="Random number is: ", width=20)
izpis_stevila = Label(root, text="" + stevilo)

#Showcase of gui
navodilo.grid(row=0, column=0, columnspan=1)
navodilo2.grid(row=1, column=0, columnspan=1)
navodilo3.grid(row=3, column=0, columnspan=1)
prvo_stevilo.grid(row=2, column=0, columnspan=1)
drugo_stevilo.grid(row=4, column=0, columnspan=1)
praznavrstica.grid(row=5, column=0, columnspan=1)
gumb.grid(row=6, column=0, columnspan=1)
praznavrstica.grid(row=7, column=0, columnspan=1)
izpis.grid(row=8, column=0, columnspan=1)
izpis_stevila.grid(row=9, column=0, columnspan=1)


#Loop
root.mainloop()

Answer 1

I've noticed few problems with your code. I was able to make it running without too many changes, although probably it is not the best way.

First answer to your question: you are getting this error, because you are trying to change string -> '' to int. It happens because function() is running before you click button.

Another problem:

izpis_stevila = Label(root, text="" + stevilo)

variable 'stevilo' simply doesn't exist before calling function(), so delete it from here.

My proposition for changes:

1)

gumb = Button(root, text="Generate number", width=17, height=2,command = lambda: function())

Without lambda your function will run no matter of state of your button.

2)

first = IntVar(root, value=0)
second = IntVar(root, value=1)
prvo_stevilo = Entry(root, width=20, borderwidth=3, textvariable=first)
drugo_stevilo = Entry(root, width=20, borderwidth=3, textvariable=second)

If you run function without any values in your entry you will get error. This change allows you to put default value for your entry widgets.

3)

def function():
if prvo_stevilo.get() == '' or drugo_stevilo.get() =='':
    return
else:
    string_answer1 = prvo_stevilo.get()
    int1 = int(string_answer1)
    string_answer2 = drugo_stevilo.get()
    int2 = int(string_answer2)
    stevilo = random.randint(int1, int2)
    izpis_stevila = Label(root, text=str(stevilo))
    izpis_stevila.grid(row=9, column=0)

Firstly check if your entry is not empty. Secondly update label, also remeber about changing int to string here text=str(stevilo).